Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2803)

Unified Diff: content/renderer/render_view_impl.cc

Issue 2496593002: Adding an experimental flag to block autoplay with sound in cross-origin iframes (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index bd45f5364edae9520ea4c36f17e3ba2b3a973b86..8f3246921be83e71022b6b9b90f59ed6e3a6df08 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -1153,10 +1153,18 @@ void RenderView::ApplyWebPreferences(const WebPreferences& prefs,
base::android::BuildInfo::GetInstance()->sdk_int() <=
base::android::SDK_VERSION_JELLY_BEAN_MR2 ||
base::SysInfo::IsLowEndDevice();
- settings->setForcePreloadNoneForMediaElements(is_low_end_device);
WebRuntimeFeatures::enableAutoplayMutedVideos(
prefs.autoplay_muted_videos_enabled && !is_low_end_device);
+ settings->setForcePreloadNoneForMediaElements(is_low_end_device);
settings->setSpellCheckEnabledByDefault(prefs.spellcheck_enabled_by_default);
+#else
+ WebRuntimeFeatures::enableAutoplayMutedVideos(
+ prefs.autoplay_muted_videos_enabled);
+#endif
+
+#if !defined(OS_ANDROID)
+ settings->setMediaPlaybackInCrossOriginIframesRequiresUserGesture(
+ prefs.user_gesture_required_for_media_playback_in_cross_origin_iframes);
#endif
settings->setAutoplayExperimentMode(

Powered by Google App Engine
This is Rietveld 408576698