Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1064)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2496593002: Adding an experimental flag to block autoplay with sound in cross-origin iframes (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 1937 matching lines...) Expand 10 before | Expand all | Expand 10 after
1948 switches::kDisableFullscreenTabDetaching)}, 1948 switches::kDisableFullscreenTabDetaching)},
1949 {"enable-fullscreen-toolbar-reveal", 1949 {"enable-fullscreen-toolbar-reveal",
1950 IDS_FLAGS_FULLSCREEN_TOOLBAR_REVEAL_NAME, 1950 IDS_FLAGS_FULLSCREEN_TOOLBAR_REVEAL_NAME,
1951 IDS_FLAGS_FULLSCREEN_TOOLBAR_REVEAL_DESCRIPTION, kOsMac, 1951 IDS_FLAGS_FULLSCREEN_TOOLBAR_REVEAL_DESCRIPTION, kOsMac,
1952 SINGLE_VALUE_TYPE(switches::kEnableFullscreenToolbarReveal)}, 1952 SINGLE_VALUE_TYPE(switches::kEnableFullscreenToolbarReveal)},
1953 #endif // OS_MACOSX 1953 #endif // OS_MACOSX
1954 #if defined(OS_ANDROID) 1954 #if defined(OS_ANDROID)
1955 {"important-sites-in-cbd", IDS_FLAGS_IMPORTANT_SITES_IN_CBD_NAME, 1955 {"important-sites-in-cbd", IDS_FLAGS_IMPORTANT_SITES_IN_CBD_NAME,
1956 IDS_FLAGS_IMPORTANT_SITES_IN_CBD_DESCRIPTION, kOsAndroid, 1956 IDS_FLAGS_IMPORTANT_SITES_IN_CBD_DESCRIPTION, kOsAndroid,
1957 FEATURE_VALUE_TYPE(chrome::android::kImportantSitesInCBD)}, 1957 FEATURE_VALUE_TYPE(chrome::android::kImportantSitesInCBD)},
1958 #endif // OS_ANDROID
1958 {"autoplay-muted-videos", IDS_FLAGS_ENABLE_AUTOPLAY_MUTED_VIDEOS_NAME, 1959 {"autoplay-muted-videos", IDS_FLAGS_ENABLE_AUTOPLAY_MUTED_VIDEOS_NAME,
1959 IDS_FLAGS_ENABLE_AUTOPLAY_MUTED_VIDEOS_DESCRIPTION, kOsAndroid, 1960 IDS_FLAGS_ENABLE_AUTOPLAY_MUTED_VIDEOS_DESCRIPTION, kOsAll,
1960 FEATURE_VALUE_TYPE(features::kAutoplayMutedVideos)}, 1961 FEATURE_VALUE_TYPE(features::kAutoplayMutedVideos)},
1961 #endif // OS_ANDROID
1962 {"enable-pointer-events", IDS_FLAGS_EXPERIMENTAL_POINTER_EVENT_NAME, 1962 {"enable-pointer-events", IDS_FLAGS_EXPERIMENTAL_POINTER_EVENT_NAME,
1963 IDS_FLAGS_EXPERIMENTAL_POINTER_EVENT_DESCRIPTION, kOsAll, 1963 IDS_FLAGS_EXPERIMENTAL_POINTER_EVENT_DESCRIPTION, kOsAll,
1964 FEATURE_VALUE_TYPE(features::kPointerEvents)}, 1964 FEATURE_VALUE_TYPE(features::kPointerEvents)},
1965 {"passive-listener-default", IDS_FLAGS_PASSIVE_EVENT_LISTENER_DEFAULT_NAME, 1965 {"passive-listener-default", IDS_FLAGS_PASSIVE_EVENT_LISTENER_DEFAULT_NAME,
1966 IDS_FLAGS_PASSIVE_EVENT_LISTENER_DEFAULT_DESCRIPTION, kOsAll, 1966 IDS_FLAGS_PASSIVE_EVENT_LISTENER_DEFAULT_DESCRIPTION, kOsAll,
1967 MULTI_VALUE_TYPE(kPassiveListenersChoices)}, 1967 MULTI_VALUE_TYPE(kPassiveListenersChoices)},
1968 {"document-passive-event-listeners", 1968 {"document-passive-event-listeners",
1969 IDS_FLAGS_PASSIVE_DOCUMENT_EVENT_LISTENERS_NAME, 1969 IDS_FLAGS_PASSIVE_DOCUMENT_EVENT_LISTENERS_NAME,
1970 IDS_FLAGS_PASSIVE_DOCUMENT_EVENT_LISTENERS_DESCRIPTION, kOsAll, 1970 IDS_FLAGS_PASSIVE_DOCUMENT_EVENT_LISTENERS_DESCRIPTION, kOsAll,
1971 FEATURE_VALUE_TYPE(features::kPassiveDocumentEventListeners)}, 1971 FEATURE_VALUE_TYPE(features::kPassiveDocumentEventListeners)},
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
2098 {"enable-consistent-omnibox-geolocation", 2098 {"enable-consistent-omnibox-geolocation",
2099 IDS_FLAGS_ENABLE_CONSISTENT_OMNIBOX_GEOLOCATION_NAME, 2099 IDS_FLAGS_ENABLE_CONSISTENT_OMNIBOX_GEOLOCATION_NAME,
2100 IDS_FLAGS_ENABLE_CONSISTENT_OMNIBOX_GEOLOCATION_DESCRIPTION, kOsAndroid, 2100 IDS_FLAGS_ENABLE_CONSISTENT_OMNIBOX_GEOLOCATION_DESCRIPTION, kOsAndroid,
2101 FEATURE_VALUE_TYPE(features::kConsistentOmniboxGeolocation)}, 2101 FEATURE_VALUE_TYPE(features::kConsistentOmniboxGeolocation)},
2102 {"concurrent-background-loading-on-svelte", 2102 {"concurrent-background-loading-on-svelte",
2103 IDS_FLAGS_OFFLINE_PAGES_SVELTE_CONCURRENT_LOADING_NAME, 2103 IDS_FLAGS_OFFLINE_PAGES_SVELTE_CONCURRENT_LOADING_NAME,
2104 IDS_FLAGS_OFFLINE_PAGES_SVELTE_CONCURRENT_LOADING_DESCRIPTION, kOsAndroid, 2104 IDS_FLAGS_OFFLINE_PAGES_SVELTE_CONCURRENT_LOADING_DESCRIPTION, kOsAndroid,
2105 FEATURE_VALUE_TYPE( 2105 FEATURE_VALUE_TYPE(
2106 offline_pages::kOfflinePagesSvelteConcurrentLoadingFeature)}, 2106 offline_pages::kOfflinePagesSvelteConcurrentLoadingFeature)},
2107 #endif 2107 #endif
2108 #if !defined(OS_ANDROID)
2109 {"media-playback-in-cross-origin-iframes-requires-user-gesture",
2110 IDS_FLAGS_MEDIA_PLAYBACK_IN_CROSS_ORIGIN_IFRAMES_REQUIRES_USER_GESTURE_NAME ,
2111 IDS_FLAGS_MEDIA_PLAYBACK_IN_CROSS_ORIGIN_IFRAMES_REQUIRES_USER_GESTURE_DESC RIPTION,
2112 kOsDesktop,
2113 FEATURE_VALUE_TYPE(
2114 features::kUserGestureRequiredForMediaPlaybackInCrossOriginIframes)},
2115 #endif
2108 // NOTE: Adding new command-line switches requires adding corresponding 2116 // NOTE: Adding new command-line switches requires adding corresponding
2109 // entries to enum "LoginCustomFlags" in histograms.xml. See note in 2117 // entries to enum "LoginCustomFlags" in histograms.xml. See note in
2110 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test. 2118 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.
2111 }; 2119 };
2112 2120
2113 class FlagsStateSingleton { 2121 class FlagsStateSingleton {
2114 public: 2122 public:
2115 FlagsStateSingleton() 2123 FlagsStateSingleton()
2116 : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {} 2124 : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {}
2117 ~FlagsStateSingleton() {} 2125 ~FlagsStateSingleton() {}
(...skipping 188 matching lines...) Expand 10 before | Expand all | Expand 10 after
2306 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2314 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2307 2315
2308 const FeatureEntry* GetFeatureEntries(size_t* count) { 2316 const FeatureEntry* GetFeatureEntries(size_t* count) {
2309 *count = arraysize(kFeatureEntries); 2317 *count = arraysize(kFeatureEntries);
2310 return kFeatureEntries; 2318 return kFeatureEntries;
2311 } 2319 }
2312 2320
2313 } // namespace testing 2321 } // namespace testing
2314 2322
2315 } // namespace about_flags 2323 } // namespace about_flags
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698