Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issue 2496573003: Add CullRect::toString (Closed)

Created:
4 years, 1 month ago by pdr.
Modified:
4 years, 1 month ago
Reviewers:
szager1
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add CullRect::toString Hit this with szager and it was the last straw. Lets add a toString helper to make CullRect more debuggable. The implementation just forwards to the IntRect toString. BUG=632096 Committed: https://crrev.com/fc7473554b53ff5aa7b54fe2b51298c2bc43cbb6 Cr-Commit-Position: refs/heads/master@{#431401}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/WebKit/Source/platform/graphics/paint/CullRect.h View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
pdr.
4 years, 1 month ago (2016-11-10 21:53:22 UTC) #4
szager1
lgtm
4 years, 1 month ago (2016-11-10 22:15:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2496573003/1
4 years, 1 month ago (2016-11-10 23:41:01 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 00:22:32 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 00:26:27 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc7473554b53ff5aa7b54fe2b51298c2bc43cbb6
Cr-Commit-Position: refs/heads/master@{#431401}

Powered by Google App Engine
This is Rietveld 408576698