Add header files that were missing from BUILD.gn.

Add header files that were missing from BUILD.gn.

Those headers files are part of the targets but not listed in their
sources properties meaning that "gn check" ignores them which can
lead to incorrect dependencies.

The files were found by inspecting headers included from ios targets
downstream that were not listed in the generated Xcode project.

BUG=None

Committed: https://crrev.com/ed4f8cdf3476e743759bf3a8c6e9ce95d95f3c7a
Cr-Commit-Position: refs/heads/master@{#432862}

[sdefresne, 2016-11-10 15:22:03]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[sdefresne, 2016-11-10 15:22:15]

sdefresne@chromium.org changed reviewers:
+ brettw@chromium.org

[sdefresne, 2016-11-10 15:22:15]

Please take a look.

[commit-bot: I haz the power, 2016-11-10 15:22:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 15:30:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 15:30:49]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[brettw, 2016-11-10 20:36:06]

lgtm

[sdefresne, 2016-11-14 07:55:34]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 07:55:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2016-11-14 08:08:02]

Patchset #2 (id:20001) has been deleted

[sdefresne, 2016-11-14 08:08:23]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 08:08:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 09:02:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 09:02:05]

Dry run: This issue passed the CQ dry run.

[sdefresne, 2016-11-14 15:04:10]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2016-11-14 15:04:10]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2496573002/#ps40001
(title: "Add dependency on //components/keyed_service/core")

[commit-bot: I haz the power, 2016-11-14 15:04:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 19:16:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 19:16:39]

Failed to apply patch for ios/public/provider/chrome/browser/BUILD.gn:
While running git apply --index -p1;
  error: patch failed: ios/public/provider/chrome/browser/BUILD.gn:16
  error: ios/public/provider/chrome/browser/BUILD.gn: patch does not apply

Patch:       ios/public/provider/chrome/browser/BUILD.gn
Index: ios/public/provider/chrome/browser/BUILD.gn
diff --git a/ios/public/provider/chrome/browser/BUILD.gn
b/ios/public/provider/chrome/browser/BUILD.gn
index
61bab28523c5702e2e9cbe04279e9b7796ac13c8..388968f6f6ed0dcfe4605278c7eefe14d2b1b6dc
100644
--- a/ios/public/provider/chrome/browser/BUILD.gn
+++ b/ios/public/provider/chrome/browser/BUILD.gn
@@ -16,6 +16,7 @@ source_set("browser") {
     "native_app_launcher/native_app_types.h",
     "omaha/omaha_service_provider.h",
     "omaha/omaha_service_provider.mm",
+    "sessions/live_tab_context_provider.h",
     "signin/chrome_identity.h",
     "signin/chrome_identity.mm",
     "signin/chrome_identity_browser_opener.h",

[sdefresne, 2016-11-16 10:11:14]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[sdefresne, 2016-11-16 10:11:15]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2016-11-16 10:11:16]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2496573002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-11-16 10:11:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 12:12:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 12:12:30]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sdefresne, 2016-11-16 16:00:16]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2016-11-16 16:00:38]

Resending to CQ as failure seems to be unrelated.

[commit-bot: I haz the power, 2016-11-16 16:00:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 18:16:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 18:16:56]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[sdefresne, 2016-11-17 07:44:07]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 07:44:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 08:33:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 08:33:28]

Dry run: This issue passed the CQ dry run.

[sdefresne, 2016-11-17 10:06:08]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2016-11-17 10:06:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 10:09:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 10:09:41]

Failed to apply patch for ios/public/provider/chrome/browser/BUILD.gn:
While running git apply --index -p1;
  error: patch failed: ios/public/provider/chrome/browser/BUILD.gn:18
  error: ios/public/provider/chrome/browser/BUILD.gn: patch does not apply

Patch:       ios/public/provider/chrome/browser/BUILD.gn
Index: ios/public/provider/chrome/browser/BUILD.gn
diff --git a/ios/public/provider/chrome/browser/BUILD.gn
b/ios/public/provider/chrome/browser/BUILD.gn
index
7fda8ca3eaeb9e107d78b6ba9ae50475b5e01758..6bbfc4bfde6978ce7379a3f1ae7d0255030acb8e
100644
--- a/ios/public/provider/chrome/browser/BUILD.gn
+++ b/ios/public/provider/chrome/browser/BUILD.gn
@@ -18,6 +18,7 @@ source_set("browser") {
     "native_app_launcher/native_app_whitelist_manager.h",
     "omaha/omaha_service_provider.h",
     "omaha/omaha_service_provider.mm",
+    "sessions/live_tab_context_provider.h",
     "signin/chrome_identity.h",
     "signin/chrome_identity.mm",
     "signin/chrome_identity_browser_opener.h",

[sdefresne, 2016-11-17 10:26:40]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[sdefresne, 2016-11-17 10:26:42]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2016-11-17 10:26:42]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2496573002/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2016-11-17 10:26:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 12:20:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 12:20:14]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[sdefresne, 2016-11-17 13:07:34]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2016-11-17 13:07:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 14:15:26]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-11-17 14:17:11]

Description was changed from

==========
Add header files that were missing from BUILD.gn.

Those headers files are part of the targets but not listed in their
sources properties meaning that "gn check" ignores them which can
lead to incorrect dependencies.

The files were found by inspecting headers included from ios targets
downstream that were not listed in the generated Xcode project.

BUG=None
==========

to

==========
Add header files that were missing from BUILD.gn.

Those headers files are part of the targets but not listed in their
sources properties meaning that "gn check" ignores them which can
lead to incorrect dependencies.

The files were found by inspecting headers included from ios targets
downstream that were not listed in the generated Xcode project.

BUG=None

Committed: https://crrev.com/ed4f8cdf3476e743759bf3a8c6e9ce95d95f3c7a
Cr-Commit-Position: refs/heads/master@{#432862}
==========

[commit-bot: I haz the power, 2016-11-17 14:17:13]

Patchset 4 (id:??) landed as
https://crrev.com/ed4f8cdf3476e743759bf3a8c6e9ce95d95f3c7a
Cr-Commit-Position: refs/heads/master@{#432862}