Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2496553002: Use relative address for images. (Closed)

Created:
4 years, 1 month ago by Olivier
Modified:
4 years, 1 month ago
Reviewers:
jif, jif-google
CC:
chromium-reviews, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use relative address for images. There is no readon to use absolute address. It is easier with WKWebView to have relative addresses. Also DomDistiller sometaimes escapes URL, so test the images URLs escaped. BUG=664124 Committed: https://crrev.com/597a121d5e90c67564f0226d66c7e02984c3df8f Cr-Commit-Position: refs/heads/master@{#431275}

Patch Set 1 #

Total comments: 2

Patch Set 2 : feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M ios/chrome/browser/reading_list/url_downloader.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/reading_list/url_downloader.cc View 1 3 chunks +10 lines, -7 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
Olivier
4 years, 1 month ago (2016-11-10 14:36:11 UTC) #2
jif-google
lgtm https://codereview.chromium.org/2496553002/diff/1/ios/chrome/browser/reading_list/url_downloader.cc File ios/chrome/browser/reading_list/url_downloader.cc (right): https://codereview.chromium.org/2496553002/diff/1/ios/chrome/browser/reading_list/url_downloader.cc#newcode230 ios/chrome/browser/reading_list/url_downloader.cc:230: if (pos == std::string::npos) { if dom distiller ...
4 years, 1 month ago (2016-11-10 15:04:52 UTC) #4
jif
lgtm
4 years, 1 month ago (2016-11-10 16:01:54 UTC) #5
Olivier
https://codereview.chromium.org/2496553002/diff/1/ios/chrome/browser/reading_list/url_downloader.cc File ios/chrome/browser/reading_list/url_downloader.cc (right): https://codereview.chromium.org/2496553002/diff/1/ios/chrome/browser/reading_list/url_downloader.cc#newcode230 ios/chrome/browser/reading_list/url_downloader.cc:230: if (pos == std::string::npos) { On 2016/11/10 15:04:51, jif-google ...
4 years, 1 month ago (2016-11-10 16:42:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2496553002/20001
4 years, 1 month ago (2016-11-10 16:42:30 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-10 16:52:39 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 16:55:03 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/597a121d5e90c67564f0226d66c7e02984c3df8f
Cr-Commit-Position: refs/heads/master@{#431275}

Powered by Google App Engine
This is Rietveld 408576698