Use relative address for images.

Use relative address for images.

There is no readon to use absolute address.
It is easier with WKWebView to have relative addresses.
Also DomDistiller sometaimes escapes URL, so test the images URLs escaped.

BUG=664124
Committed: https://crrev.com/597a121d5e90c67564f0226d66c7e02984c3df8f
Cr-Commit-Position: refs/heads/master@{#431275}

[Olivier, 2016-11-10 14:36:10]

olivierrobin@chromium.org changed reviewers:
+ jif@chromium.org

[jif-google, 2016-11-10 15:04:51]

jif@google.com changed reviewers:
+ jif@google.com

[jif-google, 2016-11-10 15:04:52]

lgtm

https://codereview.chromium.org/2496553002/diff/1/ios/chrome/browser/reading_...
File ios/chrome/browser/reading_list/url_downloader.cc (right):

https://codereview.chromium.org/2496553002/diff/1/ios/chrome/browser/reading_...
ios/chrome/browser/reading_list/url_downloader.cc:230: if (pos ==
std::string::npos) {
if dom distiller will include the image at most once, remove the while.
if dom distiller always escapes the urls, always escape the url.

[jif, 2016-11-10 16:01:54]

lgtm

[Olivier, 2016-11-10 16:42:01]

The CQ bit was checked by olivierrobin@chromium.org

[Olivier, 2016-11-10 16:42:02]

The patchset sent to the CQ was uploaded after l-g-t-m from jif@chromium.org,
jif@google.com
Link to the patchset: https://codereview.chromium.org/2496553002/#ps20001
(title: "feedback")

[Olivier, 2016-11-10 16:42:11]

https://codereview.chromium.org/2496553002/diff/1/ios/chrome/browser/reading_...
File ios/chrome/browser/reading_list/url_downloader.cc (right):

https://codereview.chromium.org/2496553002/diff/1/ios/chrome/browser/reading_...
ios/chrome/browser/reading_list/url_downloader.cc:230: if (pos ==
std::string::npos) {
On 2016/11/10 15:04:51, jif-google wrote:
> if dom distiller will include the image at most once, remove the while.
> if dom distiller always escapes the urls, always escape the url.

Done.

[commit-bot: I haz the power, 2016-11-10 16:42:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 16:52:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-10 16:55:03]

Description was changed from

==========
Use relative address for images.

There is no readon to use absolute address.
It is easier with WKWebView to have relative addresses.
Also DomDistiller sometaimes escapes URL, so test the images URLs escaped.

BUG=664124
==========

to

==========
Use relative address for images.

There is no readon to use absolute address.
It is easier with WKWebView to have relative addresses.
Also DomDistiller sometaimes escapes URL, so test the images URLs escaped.

BUG=664124

Committed: https://crrev.com/597a121d5e90c67564f0226d66c7e02984c3df8f
Cr-Commit-Position: refs/heads/master@{#431275}
==========

[commit-bot: I haz the power, 2016-11-10 16:55:03]

Patchset 2 (id:??) landed as
https://crrev.com/597a121d5e90c67564f0226d66c7e02984c3df8f
Cr-Commit-Position: refs/heads/master@{#431275}