document.open(): gracefully handle exception thrown on window.open access.

document.open(): gracefully handle exception thrown on window.open access.

Check if the "open" property lookup on the global object returned anything
before attempting to use it.

R=haraken@chromium.org
BUG=365659
TEST=fast/js/document-open-getter-throw-no-crash.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172407

[sof, 2014-04-23 16:23:27]

Please take a look.

Test in the right place (and of the expected form)?

[haraken, 2014-04-23 16:27:24]

Does this behavior align with other browsers and the spec? (It was not clear
from the bug description.)

[sof, 2014-04-23 16:38:06]

On 2014/04/23 16:27:24, haraken wrote:
> Does this behavior align with other browsers and the spec? (It was not clear
> from the bug description.)

We crash without it & there are no [Unforgeable] on document.open() and/or
window.open() in the spec to prevent defining a getter like this.

[haraken, 2014-04-23 16:46:11]

On 2014/04/23 16:38:06, sof wrote:
> On 2014/04/23 16:27:24, haraken wrote:
> > Does this behavior align with other browsers and the spec? (It was not clear
> > from the bug description.)
> 
> We crash without it & there are no [Unforgeable] on document.open() and/or
> window.open() in the spec to prevent defining a getter like this.

That makes sense. LGTM.

[sof, 2014-04-23 18:08:41]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2014-04-23 18:08:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sigbjornf@opera.com/249653002/1

[commit-bot: I haz the power, 2014-04-23 21:19:06]

Change committed as 172407