Disable WebAPK updates when "installation from unknown sources" is disabled

Disable WebAPK updates when "installation from unknown sources" is disabled

When a WebAPK tries to update itself and the user has "installation from
unknown sources" disabled, the Android system displays a prompt requesting that
the user enable "installation from unknown sources". The Android system prompt
does not indicate that it is for an "update" instead of for an "install". This
makes showing the prompt confusing in the update scenario.

Do not request updates if the user disabled "installation from unknown sources".

BUG=661800
Committed: https://crrev.com/58b2585e2e7c567bcb23f919c8a4f2afafc18301
Cr-Commit-Position: refs/heads/master@{#431392}

[pkotwicz, 2016-11-10 03:03:54]

Description was changed from

==========
Disable WebAPK updates when "installation from unknown sources" is disabled

When a WebAPK tries to update itself and the user has "installation from unknown
sources" disabled, the Android system displays a prompt requesting that the user
enable "installation from unknown sources". The Android system prompt does not
indicate that it is for an "update" instead of for an "install". This makes
showing the prompt confusing in the update scenario.

Do not request updates if the user disabled "installation from unknown sources".

BUG=661800
==========

to

==========
Disable WebAPK updates when "installation from unknown sources" is disabled

When a WebAPK tries to update itself and the user has "installation from
unknown sources" disabled, the Android system displays a prompt requesting that
the user enable "installation from unknown sources". The Android system prompt
does not indicate that it is for an "update" instead of for an "install". This
makes showing the prompt confusing in the update scenario.

Do not request updates if the user disabled "installation from unknown sources".

BUG=661800
==========

[pkotwicz, 2016-11-10 03:03:54]

pkotwicz@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[pkotwicz, 2016-11-10 03:04:06]

Dan, can you please take a look?

[pkotwicz, 2016-11-10 03:13:26]

Patchset #2 (id:20001) has been deleted

[pkotwicz, 2016-11-10 03:13:46]

Patchset #1 (id:1) has been deleted

[gone, 2016-11-10 18:20:30]

https://codereview.chromium.org/2496443002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java
(right):

https://codereview.chromium.org/2496443002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java:273:
context.getContentResolver(), Settings.Secure.INSTALL_NON_MARKET_APPS)
Indentation here is all over the place...  Pull out something into a temporary
variable or something to make it easier to parse.

[pkotwicz, 2016-11-10 20:19:19]

dfalcantara@ can you please take another look?

https://codereview.chromium.org/2496443002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java
(right):

https://codereview.chromium.org/2496443002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java:273:
context.getContentResolver(), Settings.Secure.INSTALL_NON_MARKET_APPS)
On 2016/11/10 18:20:30, dfalcantara (check my queue) wrote:
> Indentation here is all over the place...  Pull out something into a temporary
> variable or something to make it easier to parse.

Done.

[gone, 2016-11-10 21:52:31]

lgtm

[pkotwicz, 2016-11-10 22:29:32]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2016-11-10 22:30:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 23:16:18]

Description was changed from

==========
Disable WebAPK updates when "installation from unknown sources" is disabled

When a WebAPK tries to update itself and the user has "installation from
unknown sources" disabled, the Android system displays a prompt requesting that
the user enable "installation from unknown sources". The Android system prompt
does not indicate that it is for an "update" instead of for an "install". This
makes showing the prompt confusing in the update scenario.

Do not request updates if the user disabled "installation from unknown sources".

BUG=661800
==========

to

==========
Disable WebAPK updates when "installation from unknown sources" is disabled

When a WebAPK tries to update itself and the user has "installation from
unknown sources" disabled, the Android system displays a prompt requesting that
the user enable "installation from unknown sources". The Android system prompt
does not indicate that it is for an "update" instead of for an "install". This
makes showing the prompt confusing in the update scenario.

Do not request updates if the user disabled "installation from unknown sources".

BUG=661800
==========

[commit-bot: I haz the power, 2016-11-10 23:16:19]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-11-10 23:28:48]

Description was changed from

==========
Disable WebAPK updates when "installation from unknown sources" is disabled

When a WebAPK tries to update itself and the user has "installation from
unknown sources" disabled, the Android system displays a prompt requesting that
the user enable "installation from unknown sources". The Android system prompt
does not indicate that it is for an "update" instead of for an "install". This
makes showing the prompt confusing in the update scenario.

Do not request updates if the user disabled "installation from unknown sources".

BUG=661800
==========

to

==========
Disable WebAPK updates when "installation from unknown sources" is disabled

When a WebAPK tries to update itself and the user has "installation from
unknown sources" disabled, the Android system displays a prompt requesting that
the user enable "installation from unknown sources". The Android system prompt
does not indicate that it is for an "update" instead of for an "install". This
makes showing the prompt confusing in the update scenario.

Do not request updates if the user disabled "installation from unknown sources".

BUG=661800

Committed: https://crrev.com/58b2585e2e7c567bcb23f919c8a4f2afafc18301
Cr-Commit-Position: refs/heads/master@{#431392}
==========

[commit-bot: I haz the power, 2016-11-10 23:28:48]

Patchset 2 (id:??) landed as
https://crrev.com/58b2585e2e7c567bcb23f919c8a4f2afafc18301
Cr-Commit-Position: refs/heads/master@{#431392}