Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2496433004: Cherry pick an upstream patch for tz dir traversal (Closed)

Created:
4 years, 1 month ago by jungshik at Google
Modified:
4 years, 1 month ago
Reviewers:
xyzzyz
CC:
chromium-reviews
Target Ref:
refs/heads/chromium/m55
Project:
icu
Visibility:
Public.

Description

Cherry pick an upstream patch for tz dir traversal Upstream bug: http://bugs.icu-project.org/trac/ticket/12798 CLs: http://bugs.icu-project.org/trac/review/12798 This is for M55 branch (ICU 56.1). Trunk/M56 has ICU 58.1 with this fix. BUG=654090 TEST=See the bug R=xyzzyz@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/icu/+/937c159e1e0e7ad726fcad97f893c5fd2e2ab869

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+252 lines, -28 lines) Patch
M README.chromium View 1 chunk +4 lines, -0 lines 0 comments Download
A patches/tzpath.patch View 1 chunk +184 lines, -0 lines 0 comments Download
M source/common/putil.cpp View 5 chunks +50 lines, -18 lines 0 comments Download
M source/tools/toolutil/filetools.cpp View 4 chunks +14 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
jungshik at Google
PTAL. Thanks
4 years, 1 month ago (2016-11-11 18:03:34 UTC) #2
xyzzyz
lgtm I don't have access to bugstream bug though, so I cannot cross check it ...
4 years, 1 month ago (2016-11-11 18:31:26 UTC) #3
jungshik at Google
On 2016/11/11 18:31:26, xyzzyz wrote: > lgtm > > I don't have access to bugstream ...
4 years, 1 month ago (2016-11-11 20:33:36 UTC) #4
jungshik at Google
4 years, 1 month ago (2016-11-11 20:34:47 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
937c159e1e0e7ad726fcad97f893c5fd2e2ab869 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698