arc: enable use_new_wrapper_types for notifications.mojom

arc: enable use_new_wrapper_types for notifications.mojom

BUG=662510
BUG=624136
TEST=try

Committed: https://crrev.com/4554b46f099cc837d4f5aa574a67541eccc0f150
Cr-Commit-Position: refs/heads/master@{#432313}

[Yusuke Sato, 2016-11-15 07:29:26]

The CQ bit was checked by yusukes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 07:29:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 07:46:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 07:46:48]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Yusuke Sato, 2016-11-15 17:58:27]

The CQ bit was checked by yusukes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 17:59:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 18:54:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 18:54:05]

Dry run: This issue passed the CQ dry run.

[Yusuke Sato, 2016-11-15 18:55:58]

Description was changed from

==========
arc: enable use_new_wrapper_types for notifications.mojom

BUG=662510
TEST=try
==========

to

==========
arc: enable use_new_wrapper_types for notifications.mojom

BUG=662510
BUG=624136
TEST=try
==========

[Yusuke Sato, 2016-11-15 19:19:17]

yusukes@chromium.org changed reviewers:
+ lhchavez@chromium.org, yoshiki@chromium.org

[Yusuke Sato, 2016-11-15 19:19:17]

I have 3 migration CLs and this is the first one. Luis: PTAL. Yoshiki: FYI.

https://codereview.chromium.org/2496423004/diff/20001/ui/arc/notification/arc...
File ui/arc/notification/arc_custom_notification_item.cc (left):

https://codereview.chromium.org/2496423004/diff/20001/ui/arc/notification/arc...
ui/arc/notification/arc_custom_notification_item.cc:78:
DCHECK(!data->title.is_null());
Since title is not optional, the check does nothing.

https://codereview.chromium.org/2496423004/diff/20001/ui/arc/notification/arc...
ui/arc/notification/arc_custom_notification_item.cc:79:
DCHECK(!data->message.is_null());
same

https://codereview.chromium.org/2496423004/diff/20001/ui/arc/notification/arc...
File ui/arc/notification/arc_notification_item.cc (left):

https://codereview.chromium.org/2496423004/diff/20001/ui/arc/notification/arc...
ui/arc/notification/arc_notification_item.cc:235:
DCHECK(!data->icon_data.is_null());
same

[Luis Héctor Chávez, 2016-11-15 19:22:59]

lgtm

https://codereview.chromium.org/2496423004/diff/20001/ui/arc/notification/arc...
File ui/arc/notification/arc_notification_manager.cc (right):

https://codereview.chromium.org/2496423004/diff/20001/ui/arc/notification/arc...
ui/arc/notification/arc_notification_manager.cc:241:
base::UTF8ToUTF16(data->text.has_value() ? *data->text : ""));
nit: s/""/std::string()/

[Yusuke Sato, 2016-11-15 19:27:35]

https://codereview.chromium.org/2496423004/diff/20001/ui/arc/notification/arc...
File ui/arc/notification/arc_notification_manager.cc (right):

https://codereview.chromium.org/2496423004/diff/20001/ui/arc/notification/arc...
ui/arc/notification/arc_notification_manager.cc:241:
base::UTF8ToUTF16(data->text.has_value() ? *data->text : ""));
On 2016/11/15 19:22:59, Luis Héctor Chávez wrote:
> nit: s/""/std::string()/

Done.

[Yusuke Sato, 2016-11-15 19:29:45]

The CQ bit was checked by yusukes@chromium.org

[Yusuke Sato, 2016-11-15 19:29:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
lhchavez@chromium.org
Link to the patchset: https://codereview.chromium.org/2496423004/#ps40001
(title: "address comment")

[commit-bot: I haz the power, 2016-11-15 19:30:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 19:47:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 19:47:46]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Yusuke Sato, 2016-11-15 20:29:05]

The CQ bit was checked by yusukes@chromium.org

[commit-bot: I haz the power, 2016-11-15 20:29:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 20:45:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 20:45:18]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Yusuke Sato, 2016-11-15 21:31:56]

The CQ bit was checked by yusukes@chromium.org

[commit-bot: I haz the power, 2016-11-15 21:32:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 21:44:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 21:44:43]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Yusuke Sato, 2016-11-15 22:04:24]

The CQ bit was checked by yusukes@chromium.org

[commit-bot: I haz the power, 2016-11-15 22:04:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 22:33:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 22:33:11]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Yusuke Sato, 2016-11-15 23:40:55]

The CQ bit was checked by yusukes@chromium.org

[commit-bot: I haz the power, 2016-11-15 23:41:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 00:26:33]

Description was changed from

==========
arc: enable use_new_wrapper_types for notifications.mojom

BUG=662510
BUG=624136
TEST=try
==========

to

==========
arc: enable use_new_wrapper_types for notifications.mojom

BUG=662510
BUG=624136
TEST=try
==========

[commit-bot: I haz the power, 2016-11-16 00:26:34]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-16 00:31:32]

Description was changed from

==========
arc: enable use_new_wrapper_types for notifications.mojom

BUG=662510
BUG=624136
TEST=try
==========

to

==========
arc: enable use_new_wrapper_types for notifications.mojom

BUG=662510
BUG=624136
TEST=try

Committed: https://crrev.com/4554b46f099cc837d4f5aa574a67541eccc0f150
Cr-Commit-Position: refs/heads/master@{#432313}
==========

[commit-bot: I haz the power, 2016-11-16 00:31:33]

Patchset 3 (id:??) landed as
https://crrev.com/4554b46f099cc837d4f5aa574a67541eccc0f150
Cr-Commit-Position: refs/heads/master@{#432313}