Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2496323002: [builtins] Take fast path in Array.prototype.keys() only if length is an Smi (Closed)

Created:
4 years, 1 month ago by caitp
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Take fast path in Array.prototype.keys() only if length is an Smi Do not take the fast path for Array.prototype.keys() if the array length is not guaranteed to be an Smi. BUG=660925, v8:5388 R=bmeurer@chromium.org, mstarzinger@chromium.org Committed: https://crrev.com/2a350ed4573252328c9e150f1c8ff8874703254a Cr-Commit-Position: refs/heads/master@{#40976}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -19 lines) Patch
M src/code-stub-assembler.cc View 2 chunks +22 lines, -19 lines 0 comments Download
A test/mjsunit/es6/regress/regress-660925.js View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
caitp
Take a look when you get some time.
4 years, 1 month ago (2016-11-14 18:46:41 UTC) #5
Benedikt Meurer
Nice, LGTM. Thanks.
4 years, 1 month ago (2016-11-14 18:49:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2496323002/1
4 years, 1 month ago (2016-11-14 18:50:04 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-14 18:52:04 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:33:14 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2a350ed4573252328c9e150f1c8ff8874703254a
Cr-Commit-Position: refs/heads/master@{#40976}

Powered by Google App Engine
This is Rietveld 408576698