cc: Build Image to Region map during image meta-data generation.

cc: Build Image to Region map during image meta-data generation.

During the discardable image meta-data generation phase, we build an
Rtree to pull the set of images given a rect. This change adds a
reverse lookup map to be built at the same time for querying the region
for an image in a DisplayItemList.

BUG=665266
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/fc85c1aa0881047c4410cbedc1e4543bcf789a1f
Cr-Commit-Position: refs/heads/master@{#432841}

[Khushal, 2016-11-15 03:13:21]

Description was changed from

==========
cc: Build Image to Region map during image meta-data generation.

During the discardable image meta-data generation phase, we build an
Rtree to pull the set of images given a rect. This change adds a
reverse lookup map to be built at the same time for querying the region
for an image in a DisplayItemList.

BUG=665266
==========

to

==========
cc: Build Image to Region map during image meta-data generation.

During the discardable image meta-data generation phase, we build an
Rtree to pull the set of images given a rect. This change adds a
reverse lookup map to be built at the same time for querying the region
for an image in a DisplayItemList.

BUG=665266
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Khushal, 2016-11-15 03:13:46]

khushalsagar@chromium.org changed reviewers:
+ vmpstr@chromium.org

[Khushal, 2016-11-15 03:13:46]

Still need to update tests.

[vmpstr, 2016-11-15 18:57:54]

Looks good, looking forward to tests.

https://codereview.chromium.org/2496283004/diff/1/cc/playback/discardable_ima...
File cc/playback/discardable_image_map.h (right):

https://codereview.chromium.org/2496283004/diff/1/cc/playback/discardable_ima...
cc/playback/discardable_image_map.h:24: using ImageToRegionMap =
std::unordered_map<uint32_t, Region>;
Can you put this as a member of DiscardableImageMap?

https://codereview.chromium.org/2496283004/diff/1/cc/playback/discardable_ima...
cc/playback/discardable_image_map.h:64: ImageToRegionMap image_to_region_;
nit: image_id_to_region_map_

[Khushal, 2016-11-16 05:01:58]

And tests.

https://codereview.chromium.org/2496283004/diff/1/cc/playback/discardable_ima...
File cc/playback/discardable_image_map.h (right):

https://codereview.chromium.org/2496283004/diff/1/cc/playback/discardable_ima...
cc/playback/discardable_image_map.h:24: using ImageToRegionMap =
std::unordered_map<uint32_t, Region>;
On 2016/11/15 18:57:54, vmpstr wrote:
> Can you put this as a member of DiscardableImageMap?

Done.

https://codereview.chromium.org/2496283004/diff/1/cc/playback/discardable_ima...
cc/playback/discardable_image_map.h:64: ImageToRegionMap image_to_region_;
On 2016/11/15 18:57:54, vmpstr wrote:
> nit: image_id_to_region_map_

Done.

[Khushal, 2016-11-16 11:16:43]

The CQ bit was checked by khushalsagar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 11:17:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 13:41:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 13:41:15]

Dry run: This issue passed the CQ dry run.

[vmpstr, 2016-11-17 00:01:20]

lgtm

[Khushal, 2016-11-17 00:03:02]

The CQ bit was checked by khushalsagar@chromium.org

[commit-bot: I haz the power, 2016-11-17 00:04:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 01:41:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 01:41:01]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Khushal, 2016-11-17 07:51:55]

The CQ bit was checked by khushalsagar@chromium.org

[Khushal, 2016-11-17 07:51:55]

The patchset sent to the CQ was uploaded after l-g-t-m from vmpstr@chromium.org
Link to the patchset: https://codereview.chromium.org/2496283004/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2016-11-17 07:52:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 08:26:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 08:26:17]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Khushal, 2016-11-17 08:32:41]

The CQ bit was checked by khushalsagar@chromium.org

[Khushal, 2016-11-17 08:32:42]

The patchset sent to the CQ was uploaded after l-g-t-m from vmpstr@chromium.org
Link to the patchset: https://codereview.chromium.org/2496283004/#ps100001
(title: "Fix Rebase")

[commit-bot: I haz the power, 2016-11-17 08:32:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 08:41:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 08:41:38]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Khushal, 2016-11-17 08:58:34]

The CQ bit was checked by khushalsagar@chromium.org

[commit-bot: I haz the power, 2016-11-17 08:58:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 11:21:35]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-11-17 11:23:38]

Description was changed from

==========
cc: Build Image to Region map during image meta-data generation.

During the discardable image meta-data generation phase, we build an
Rtree to pull the set of images given a rect. This change adds a
reverse lookup map to be built at the same time for querying the region
for an image in a DisplayItemList.

BUG=665266
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Build Image to Region map during image meta-data generation.

During the discardable image meta-data generation phase, we build an
Rtree to pull the set of images given a rect. This change adds a
reverse lookup map to be built at the same time for querying the region
for an image in a DisplayItemList.

BUG=665266
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/fc85c1aa0881047c4410cbedc1e4543bcf789a1f
Cr-Commit-Position: refs/heads/master@{#432841}
==========

[commit-bot: I haz the power, 2016-11-17 11:23:40]

Patchset 6 (id:??) landed as
https://crrev.com/fc85c1aa0881047c4410cbedc1e4543bcf789a1f
Cr-Commit-Position: refs/heads/master@{#432841}

[vmiura, 2016-12-03 04:07:07]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/2551583003/ by vmiura@chromium.org.

The reason for reverting is: Computing these image regions adds significant time
to the critical path on image heavy content.  Let's re-land after addressing the
performance.

BUG=670926.