Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: content/browser/renderer_host/render_view_host_impl.h

Issue 2496233003: Destroy the old RenderWidgetHostView when swapping out a main frame. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_ 5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_
6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_ 6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 152 matching lines...) Expand 10 before | Expand all | Expand 10 after
163 } 163 }
164 164
165 // Tracks whether this RenderViewHost is in an active state (rather than 165 // Tracks whether this RenderViewHost is in an active state (rather than
166 // pending swap out or swapped out), according to its main frame 166 // pending swap out or swapped out), according to its main frame
167 // RenderFrameHost. 167 // RenderFrameHost.
168 bool is_active() const { return is_active_; } 168 bool is_active() const { return is_active_; }
169 void set_is_active(bool is_active) { is_active_ = is_active; } 169 void set_is_active(bool is_active) { is_active_ = is_active; }
170 170
171 // Tracks whether this RenderViewHost is swapped out, according to its main 171 // Tracks whether this RenderViewHost is swapped out, according to its main
172 // frame RenderFrameHost. 172 // frame RenderFrameHost.
173 bool is_swapped_out() { return is_swapped_out_; }
Charlie Reis 2016/11/15 19:59:05 Hmm, I think we should be working to remove is_swa
lfg 2016/11/23 00:27:04 Removed in favor of using is_active.
173 void set_is_swapped_out(bool is_swapped_out) { 174 void set_is_swapped_out(bool is_swapped_out) {
174 is_swapped_out_ = is_swapped_out; 175 is_swapped_out_ = is_swapped_out;
175 } 176 }
176 177
177 // TODO(creis): Remove as part of http://crbug.com/418265. 178 // TODO(creis): Remove as part of http://crbug.com/418265.
178 bool is_waiting_for_close_ack() const { return is_waiting_for_close_ack_; } 179 bool is_waiting_for_close_ack() const { return is_waiting_for_close_ack_; }
179 180
180 // Tells the renderer process to run the page's unload handler. 181 // Tells the renderer process to run the page's unload handler.
181 // A ClosePage_ACK ack is sent back when the handler execution completes. 182 // A ClosePage_ACK ack is sent back when the handler execution completes.
182 void ClosePage(); 183 void ClosePage();
(...skipping 173 matching lines...) Expand 10 before | Expand all | Expand 10 after
356 bool render_view_ready_on_process_launch_; 357 bool render_view_ready_on_process_launch_;
357 358
358 base::WeakPtrFactory<RenderViewHostImpl> weak_factory_; 359 base::WeakPtrFactory<RenderViewHostImpl> weak_factory_;
359 360
360 DISALLOW_COPY_AND_ASSIGN(RenderViewHostImpl); 361 DISALLOW_COPY_AND_ASSIGN(RenderViewHostImpl);
361 }; 362 };
362 363
363 } // namespace content 364 } // namespace content
364 365
365 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_ 366 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698