src/wasm/wasm-module.cc - Issue 2496203002: [wasm] Reimplement function verification in the module decoder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/wasm/wasm-module.cc

Issue 2496203002: [wasm] Reimplement function verification in the module decoder. (Closed)

Patch Set: Create a dummy ModuleEnv Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/wasm/wasm-module.cc

diff --git a/src/wasm/wasm-module.cc b/src/wasm/wasm-module.cc

index 0b5ef15bc7229ba586b2c2f0e814cdc1a31583ba..80e3700eff40ad01760e20e45293b7f6a8710767 100644

--- a/src/wasm/wasm-module.cc

+++ b/src/wasm/wasm-module.cc

@@ -1925,7 +1925,7 @@ MaybeHandle<WasmModuleObject> wasm::CreateModuleObjectFromBytes(

bool wasm::ValidateModuleBytes(Isolate* isolate, const byte* start,

const byte* end, ErrorThrower* thrower,

ModuleOrigin origin) {

- ModuleResult result = DecodeWasmModule(isolate, start, end, false, origin);

+ ModuleResult result = DecodeWasmModule(isolate, start, end, true, origin);

if (result.val) {

delete result.val;

} else {

« no previous file with comments | « src/wasm/module-decoder.cc ('k') | test/common/wasm/wasm-module-runner.h » ('j') | no next file with comments »