Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 2496203002: [wasm] Reimplement function verification in the module decoder. (Closed)

Created:
4 years, 1 month ago by ahaas
Modified:
4 years, 1 month ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Reimplement function verification in the module decoder. This CL adds the function verification option to the module decoder. Therefore we can remove the verification in wasm-module-runner.cc R=titzer@chromium.org Committed: https://crrev.com/1bde83046ebb8d4b1cfa2527a649a95af73ade50 Cr-Commit-Position: refs/heads/master@{#40977}

Patch Set 1 #

Patch Set 2 : Do not verify function by default #

Patch Set 3 : typo #

Patch Set 4 : Verify functions in WebAssembly.validate #

Patch Set 5 : Create a dummy ModuleEnv #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -32 lines) Patch
M src/wasm/module-decoder.cc View 1 2 3 4 2 chunks +11 lines, -0 lines 0 comments Download
M src/wasm/wasm-module.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M test/common/wasm/wasm-module-runner.h View 1 1 chunk +3 lines, -5 lines 0 comments Download
M test/common/wasm/wasm-module-runner.cc View 1 3 chunks +5 lines, -24 lines 0 comments Download
M test/fuzzer/wasm-call.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M test/fuzzer/wasm-code.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 27 (22 generated)
ahaas
4 years, 1 month ago (2016-11-14 12:22:07 UTC) #1
titzer
On 2016/11/14 12:22:07, ahaas wrote: lgtm
4 years, 1 month ago (2016-11-14 18:45:28 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2496203002/80001
4 years, 1 month ago (2016-11-14 19:40:00 UTC) #24
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 1 month ago (2016-11-14 19:45:23 UTC) #25
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:33:17 UTC) #27
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/1bde83046ebb8d4b1cfa2527a649a95af73ade50
Cr-Commit-Position: refs/heads/master@{#40977}

Powered by Google App Engine
This is Rietveld 408576698