base/android/locale_utils.cc - Issue 2496183002: Use GetDefaultLocaleListString for returning LocaleList

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/android/locale_utils.cc

Issue 2496183002: Use GetDefaultLocaleListString for returning LocaleList (Closed)

Patch Set: extract setLocale method, since configuration.getLocales() returns the same as LocaleUtils.getDefau… Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/android/locale_utils.cc

diff --git a/base/android/locale_utils.cc b/base/android/locale_utils.cc

index b3a2346366c0b66936f3927b640a2e5e8dfa3083..a7a7c4bcda0b1f503602f2d51a1888eb573c80e3 100644

--- a/base/android/locale_utils.cc

+++ b/base/android/locale_utils.cc

@@ -23,5 +23,12 @@ std::string GetDefaultLocaleString() {

return ConvertJavaStringToUTF8(locale);

}

+std::string GetDefaultLocaleListString() {

+ JNIEnv* env = base::android::AttachCurrentThread();

+ ScopedJavaLocalRef<jstring> locales =

+ Java_LocaleUtils_getDefaultLocaleListString(env);

+ return ConvertJavaStringToUTF8(locales);

} // namespace android

} // namespace base