base/android/locale_utils.h - Issue 2496183002: Use GetDefaultLocaleListString for returning LocaleList

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/android/locale_utils.h

Issue 2496183002: Use GetDefaultLocaleListString for returning LocaleList (Closed)

Patch Set: extract setLocale method, since configuration.getLocales() returns the same as LocaleUtils.getDefau… Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef BASE_ANDROID_LOCALE_UTILS_H_	5 #ifndef BASE_ANDROID_LOCALE_UTILS_H_

6 #define BASE_ANDROID_LOCALE_UTILS_H_	6 #define BASE_ANDROID_LOCALE_UTILS_H_

7	7

8 #include <jni.h>	8 #include <jni.h>

9	9

10 #include <string>	10 #include <string>

11	11

12 #include "base/base_export.h"	12 #include "base/base_export.h"

13	13

14 namespace base {	14 namespace base {

15 namespace android {	15 namespace android {

16	16

17 BASE_EXPORT std::string GetDefaultCountryCode();	17 BASE_EXPORT std::string GetDefaultCountryCode();

18	18

19 // Return the current default locale of the device as string.	19 // Return the current default locale of the device as string.

20 BASE_EXPORT std::string GetDefaultLocaleString();	20 BASE_EXPORT std::string GetDefaultLocaleString();

	21 BASE_EXPORT std::string GetDefaultLocaleListString();
	Seigo Nonaka 2016/11/15 05:15:59 Who uses this function? If nobody uses now, let's Who uses this function? If nobody uses now, let's remove it. We should add new function when it is necessary. Yirui Huang 2016/11/16 00:23:45 Removed. This will be used once webview is fully r Show quoted text On 2016/11/15 05:15:59, Seigo Nonaka wrote: > Who uses this function? > If nobody uses now, let's remove it. > We should add new function when it is necessary. Removed. This will be used once webview is fully ready for taking a locale list.
21	22

22 } // namespace android	23 } // namespace android

23 } // namespace base	24 } // namespace base

24	25

25 #endif // BASE_ANDROID_LOCALE_UTILS_H_	26 #endif // BASE_ANDROID_LOCALE_UTILS_H_

OLD	NEW