Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: content/browser/media/media_web_contents_observer.cc

Issue 2496173003: Communicate audio state to renderer process on Android. (Closed)
Patch Set: Second iteration Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/media/media_web_contents_observer.cc
diff --git a/content/browser/media/media_web_contents_observer.cc b/content/browser/media/media_web_contents_observer.cc
index ef3f5dc9c9d5194480f0a5c99e351f872ac0491c..67aa481b11116c1ae458c3df5ea770d115eea3a8 100644
--- a/content/browser/media/media_web_contents_observer.cc
+++ b/content/browser/media/media_web_contents_observer.cc
@@ -43,7 +43,7 @@ void MediaWebContentsObserver::RenderFrameDeleted(
}
void MediaWebContentsObserver::MaybeUpdateAudibleState() {
- if (!AudioStreamMonitor::monitoring_available())
+ if (!AudioStreamMonitor::power_level_monitoring_available())
DaleCurtis 2016/11/15 19:26:01 I think this can be removed now as well as some of
altimin 2016/11/16 12:52:46 I'm a little hesitant about it — it is really a go
DaleCurtis 2016/11/16 22:16:51 Sorry if I was unclear, there should be no behavio
altimin 2016/11/17 16:13:26 Oh, I finally figured it out (previously I thought
return;
AudioStreamMonitor* audio_stream_monitor =
@@ -138,7 +138,7 @@ void MediaWebContentsObserver::OnMediaPlaying(
// If we don't have audio stream monitoring, allocate the audio power save
// blocker here instead of during NotifyNavigationStateChanged().
if (!audio_power_save_blocker_ &&
- !AudioStreamMonitor::monitoring_available()) {
+ !AudioStreamMonitor::power_level_monitoring_available()) {
CreateAudioPowerSaveBlocker();
}
}
@@ -208,7 +208,7 @@ void MediaWebContentsObserver::MaybeReleasePowerSaveBlockers() {
// monitoring, release the audio power save blocker here instead of during
// NotifyNavigationStateChanged().
if (active_audio_players_.empty() &&
- !AudioStreamMonitor::monitoring_available()) {
+ !AudioStreamMonitor::power_level_monitoring_available()) {
audio_power_save_blocker_.reset();
}

Powered by Google App Engine
This is Rietveld 408576698