Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2496163003: [Download Home] Pull out DeletedFileTracker from DownloadHistoryAdapter (Closed)

Created:
4 years, 1 month ago by gone
Modified:
4 years, 1 month ago
Reviewers:
Theresa
CC:
chromium-reviews, asanka, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Download Home] Pull out DeletedFileTracker from DownloadHistoryAdapter * Pull out the maps that track whether a DownloadItem has been deleted externally. * Clean up the logic slightly so that the DownloadItem is queried about its incognito status instead of passing around a separate boolean. * Update the tests to account for the DownloadItem tracking incognito state. BUG=654630 Committed: https://crrev.com/3d622f398a16812eee8f4fdfde7aa58b0c70b7fe Cr-Commit-Position: refs/heads/master@{#432103}

Patch Set 1 #

Messages

Total messages: 9 (3 generated)
gone
Mostly a cleanup, but I did remove some parameters assuming that DownloadItem would have them ...
4 years, 1 month ago (2016-11-14 23:25:30 UTC) #2
Theresa
lgtm. Thanks for cleaning this up.
4 years, 1 month ago (2016-11-15 01:29:05 UTC) #3
gone
Yar... plenty more to go :) Still racking my brain over how to best do ...
4 years, 1 month ago (2016-11-15 01:33:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2496163003/1
4 years, 1 month ago (2016-11-15 01:34:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-15 04:49:06 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 04:57:28 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d622f398a16812eee8f4fdfde7aa58b0c70b7fe
Cr-Commit-Position: refs/heads/master@{#432103}

Powered by Google App Engine
This is Rietveld 408576698