Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2496143003: Simplify CheckedNumeric macros (Closed)

Created:
4 years, 1 month ago by jschuh
Modified:
4 years, 1 month ago
Reviewers:
Tom Sepez
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify CheckedNumeric macros BUG=613003 Committed: https://crrev.com/657a3d6a6cfeaf22ce948ad22f98ab19f7f54a80 Cr-Commit-Position: refs/heads/master@{#432217}

Patch Set 1 #

Patch Set 2 : mostly complete #

Patch Set 3 : nit #

Patch Set 4 : compile fix #

Patch Set 5 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -129 lines) Patch
M base/numerics/safe_math.h View 1 2 3 4 2 chunks +38 lines, -75 lines 0 comments Download
M base/numerics/safe_math_impl.h View 1 2 3 4 11 chunks +136 lines, -51 lines 0 comments Download
M base/numerics/safe_numerics_unittest.cc View 1 6 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 27 (14 generated)
jschuh
mostly complete
4 years, 1 month ago (2016-11-15 00:26:50 UTC) #1
jschuh
mostly complete
4 years, 1 month ago (2016-11-15 00:27:43 UTC) #2
jschuh
mostly complete
4 years, 1 month ago (2016-11-15 00:28:51 UTC) #3
jschuh
nit
4 years, 1 month ago (2016-11-15 00:34:12 UTC) #6
jschuh
compile fix
4 years, 1 month ago (2016-11-15 03:16:10 UTC) #11
jschuh
nits
4 years, 1 month ago (2016-11-15 04:14:09 UTC) #12
jschuh
nits
4 years, 1 month ago (2016-11-15 04:47:05 UTC) #13
jschuh
PTAL. After this lands you should be able to update and land your shift operator ...
4 years, 1 month ago (2016-11-15 05:09:12 UTC) #18
jschuh
On 2016/11/15 05:09:12, jschuh (very slow) wrote: > PTAL. After this lands you should be ...
4 years, 1 month ago (2016-11-15 17:17:44 UTC) #21
Tom Sepez
lgtm
4 years, 1 month ago (2016-11-15 18:14:27 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2496143003/140001
4 years, 1 month ago (2016-11-15 18:19:07 UTC) #24
commit-bot: I haz the power
Committed patchset #5 (id:140001)
4 years, 1 month ago (2016-11-15 18:24:13 UTC) #25
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 18:33:44 UTC) #27
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/657a3d6a6cfeaf22ce948ad22f98ab19f7f54a80
Cr-Commit-Position: refs/heads/master@{#432217}

Powered by Google App Engine
This is Rietveld 408576698