[DevTools] Interactive test for DevTools touch emulation.

[DevTools] Interactive test for DevTools touch emulation.

BUG=337142
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271026

[dgozman, 2014-04-23 15:58:55]

Could you please take a look?

[jdduke (slow), 2014-04-23 16:35:52]

https://codereview.chromium.org/249613002/diff/20001/content/browser/renderer...
File content/browser/renderer_host/input/touch_emulator.cc (right):

https://codereview.chromium.org/249613002/diff/20001/content/browser/renderer...
content/browser/renderer_host/input/touch_emulator.cc:334: if
(!touch_event_.timeStampSeconds) {
Why not have the tests fill the timeStampSeconds? I'd rather do that and DCHECK
here.

[dgozman, 2014-04-23 17:27:20]

https://codereview.chromium.org/249613002/diff/20001/content/browser/renderer...
File content/browser/renderer_host/input/touch_emulator.cc (right):

https://codereview.chromium.org/249613002/diff/20001/content/browser/renderer...
content/browser/renderer_host/input/touch_emulator.cc:334: if
(!touch_event_.timeStampSeconds) {
On 2014/04/23 16:35:53, jdduke wrote:
> Why not have the tests fill the timeStampSeconds? I'd rather do that and
DCHECK
> here.

I would like that too, but interactive test issues platform events in many
different places (at least one per platform/configuration), and I doubt that I
can fix them all.

[jdduke (slow), 2014-04-23 19:29:47]

On 2014/04/23 17:27:20, dgozman wrote:
>
https://codereview.chromium.org/249613002/diff/20001/content/browser/renderer...
> File content/browser/renderer_host/input/touch_emulator.cc (right):
> 
>
https://codereview.chromium.org/249613002/diff/20001/content/browser/renderer...
> content/browser/renderer_host/input/touch_emulator.cc:334: if
> (!touch_event_.timeStampSeconds) {
> On 2014/04/23 16:35:53, jdduke wrote:
> > Why not have the tests fill the timeStampSeconds? I'd rather do that and
> DCHECK
> > here.
> 
> I would like that too, but interactive test issues platform events in many
> different places (at least one per platform/configuration), and I doubt that I
> can fix them all.

I see.  In that case, could you add a |DCHECK_NE(base::TimeTicks(),
event.GetEventTime());| to GestureProvider::OnTouchEvent
(ui/events/gesture_detection/gesture_provider.cc)?

[dgozman, 2014-04-24 10:35:28]

On 2014/04/23 19:29:47, jdduke wrote:
> On 2014/04/23 17:27:20, dgozman wrote:
> >
>
https://codereview.chromium.org/249613002/diff/20001/content/browser/renderer...
> > File content/browser/renderer_host/input/touch_emulator.cc (right):
> > 
> >
>
https://codereview.chromium.org/249613002/diff/20001/content/browser/renderer...
> > content/browser/renderer_host/input/touch_emulator.cc:334: if
> > (!touch_event_.timeStampSeconds) {
> > On 2014/04/23 16:35:53, jdduke wrote:
> > > Why not have the tests fill the timeStampSeconds? I'd rather do that and
> > DCHECK
> > > here.
> > 
> > I would like that too, but interactive test issues platform events in many
> > different places (at least one per platform/configuration), and I doubt that
I
> > can fix them all.
> 
> I see.  In that case, could you add a |DCHECK_NE(base::TimeTicks(),
> event.GetEventTime());| to GestureProvider::OnTouchEvent
> (ui/events/gesture_detection/gesture_provider.cc)?

Can't use DCHECK_NE because of to-string conversion, added DCHECK instead.
There is also |DCHECK(!gesture.time.is_null())| in GestureProvider::Send later
in pipeline.

[jdduke (slow), 2014-04-24 14:52:38]

ui/events/gesture_detection and content/browser/renderer_host/input lgtm with
nit.

https://codereview.chromium.org/249613002/diff/40001/ui/events/gesture_detect...
File ui/events/gesture_detection/gesture_provider.cc (right):

https://codereview.chromium.org/249613002/diff/40001/ui/events/gesture_detect...
ui/events/gesture_detection/gesture_provider.cc:525: DCHECK(event.GetEventTime()
!= base::TimeTicks());
Of course, yeah |DCHECK(!event.GetEventTime().is_null())| is probably better
here.

[pfeldman, 2014-04-25 11:17:59]

lgtm

[dgozman, 2014-04-25 19:46:31]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2014-04-25 22:09:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dgozman@chromium.org/249613002/120001

[commit-bot: I haz the power, 2014-04-26 00:14:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-26 00:14:15]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel

[dgozman, 2014-05-06 12:12:07]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2014-05-06 12:12:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dgozman@chromium.org/249613002/140001

[dgozman, 2014-05-06 13:35:00]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2014-05-06 13:35:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dgozman@chromium.org/249613002/160001

[commit-bot: I haz the power, 2014-05-06 15:26:22]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
  linux_chromium_rel on tryserver.chromium
  mac_chromium_rel on tryserver.chromium

[dgozman, 2014-05-06 15:42:12]

The CQ bit was unchecked by dgozman@chromium.org

[dgozman, 2014-05-16 13:00:16]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2014-05-16 13:00:41]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dgozman@chromium.org/249613002/190001

[commit-bot: I haz the power, 2014-05-16 14:53:29]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)

[commit-bot: I haz the power, 2014-05-16 15:30:05]

Change committed as 271026