ServiceWorker: Initialize EmbeddedWorkerInstanceClientImpl::wrapper_

content/renderer/service_worker/embedded_worker_instance_client_impl.cc

Index: content/renderer/service_worker/embedded_worker_instance_client_impl.cc
diff --git a/content/renderer/service_worker/embedded_worker_instance_client_impl.cc b/content/renderer/service_worker/embedded_worker_instance_client_impl.cc
index 6ef334bb81e52f7781cd00dbe77d92a3857d94a6..a504f8ea2cac9b0b4a132ece5c691364ffe18cc6 100644
--- a/content/renderer/service_worker/embedded_worker_instance_client_impl.cc
+++ b/content/renderer/service_worker/embedded_worker_instance_client_impl.cc
@@ -52,6 +52,7 @@ void EmbeddedWorkerInstanceClientImpl::StartWorker(
     service_manager::mojom::InterfaceProviderPtr browser_interfaces,
     service_manager::mojom::InterfaceProviderRequest renderer_request) {
   DCHECK(ChildThreadImpl::current());
+  DCHECK(!wrapper_);
   TRACE_EVENT0("ServiceWorker",
                "EmbeddedWorkerInstanceClientImpl::StartWorker");
   embedded_worker_id_ = params.embedded_worker_id;
@@ -75,7 +76,7 @@ void EmbeddedWorkerInstanceClientImpl::StopWorker(
   DCHECK(embedded_worker_id_);
   // StopWorker is possible to be called twice.
   if (stop_callback_ || !wrapper_) {
-    LOG(WARNING) << "Got StopWorker for stopping worker";
+    LOG(WARNING) << "Got StopWorker for stopping worker or nonexistent worker";

[falken, 2016/11/14 02:32:19]

The comment and LOG are now slightly inconsistent: the comment doesn't mention
Stop called before Start, and also now it's unclear whether a warning is really
needed since the comment seems to say this can legitimately happen.

Maybe we should remove the LOG and update the comment?

[nhiroki, 2016/11/14 04:17:40]

Done.

     return;
   }
   TRACE_EVENT0("ServiceWorker", "EmbeddedWorkerInstanceClientImpl::StopWorker");
@@ -89,7 +90,8 @@ EmbeddedWorkerInstanceClientImpl::EmbeddedWorkerInstanceClientImpl(
     mojo::InterfaceRequest<mojom::EmbeddedWorkerInstanceClient> request)
     : dispatcher_(dispatcher),
       binding_(this, std::move(request)),
-      temporal_self_(std::unique_ptr<EmbeddedWorkerInstanceClientImpl>(this)) {
+      temporal_self_(std::unique_ptr<EmbeddedWorkerInstanceClientImpl>(this)),
+      wrapper_(nullptr) {
   binding_.set_connection_error_handler(base::Bind(
       &EmbeddedWorkerInstanceClientImpl::OnError, base::Unretained(this)));
 }