Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2496063003:
[tests] disable es6/array-iterator-turbo except on turbofan and ignition (Closed)
Description[tests] skip es6/array-iterator-turbo on deopt_fuzzer
BUG=v8:5388
R=bmeurer@chromium.org
NOTRY=true
Committed: https://crrev.com/372d905d73cf9c3851519f25d1570cef96dde165
Cr-Commit-Position: refs/heads/master@{#40974}
Patch Set 1 #
Total comments: 1
Patch Set 2 : [tests] disable es6/array-iterator-turbo on deopt_fuzzer #Messages
Total messages: 24 (14 generated)
caitp@igalia.com changed reviewers: + mstarzinger@chromium.org
/CC Michael
The CQ bit was checked by caitp@igalia.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [tests] disable es6/array-iterator-turbo except on turbofan and ignition Always skip, except ion `turbofan`, `ignition` and `ignition_staging` variants. BUG=v8:5388 R=bmeurer@chromium.org ========== to ========== [tests] disable es6/array-iterator-turbo except on turbofan and ignition Always skip, except ion `turbofan`, `ignition` and `ignition_staging` variants. BUG=v8:5388 R=bmeurer@chromium.org ==========
caitp@igalia.com changed reviewers: + machenbach@chromium.org - mstarzinger@chromium.org
I guess this doesn't do what I thought it would, adding the deopt skip instead
https://codereview.chromium.org/2496063003/diff/1/test/mjsunit/mjsunit.status File test/mjsunit/mjsunit.status (right): https://codereview.chromium.org/2496063003/diff/1/test/mjsunit/mjsunit.status... test/mjsunit/mjsunit.status:607: 'es6/array-iterator-turbo': [PASS], Will this solve the problem with the deopt fuzzer? Unfortunately the deopt fuzzer output doesn't say which variant it used. The flags are: --test --random-seed=-1766313942 --deopt-every-n-times 1000000000 --print-deopt-stress --nohard-abort --nodead-code-elimination --nofold-constants --noconcurrent-recompilation --turbo --turbo-escape --allow-natives-syntax
On 2016/11/14 17:02:20, machenbach (slow) wrote: > https://codereview.chromium.org/2496063003/diff/1/test/mjsunit/mjsunit.status > File test/mjsunit/mjsunit.status (right): > > https://codereview.chromium.org/2496063003/diff/1/test/mjsunit/mjsunit.status... > test/mjsunit/mjsunit.status:607: 'es6/array-iterator-turbo': [PASS], > Will this solve the problem with the deopt fuzzer? Unfortunately the deopt > fuzzer output doesn't say which variant it used. The flags are: > --test --random-seed=-1766313942 --deopt-every-n-times 1000000000 > --print-deopt-stress --nohard-abort --nodead-code-elimination --nofold-constants > --noconcurrent-recompilation --turbo --turbo-escape --allow-natives-syntax I think it should work, but it doesn't, it just prevents the test from running at all.
Description was changed from ========== [tests] disable es6/array-iterator-turbo except on turbofan and ignition Always skip, except ion `turbofan`, `ignition` and `ignition_staging` variants. BUG=v8:5388 R=bmeurer@chromium.org ========== to ========== [tests] disable es6/array-iterator-turbo on deopt_fuzzer BUG=v8:5388 R=bmeurer@chromium.org ==========
Description was changed from ========== [tests] disable es6/array-iterator-turbo on deopt_fuzzer BUG=v8:5388 R=bmeurer@chromium.org ========== to ========== [tests] skip es6/array-iterator-turbo on deopt_fuzzer BUG=v8:5388 R=bmeurer@chromium.org ==========
The CQ bit was checked by caitp@igalia.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/11/14 17:04:33, caitp wrote: > On 2016/11/14 17:02:20, machenbach (slow) wrote: > > https://codereview.chromium.org/2496063003/diff/1/test/mjsunit/mjsunit.status > > File test/mjsunit/mjsunit.status (right): > > > > > https://codereview.chromium.org/2496063003/diff/1/test/mjsunit/mjsunit.status... > > test/mjsunit/mjsunit.status:607: 'es6/array-iterator-turbo': [PASS], > > Will this solve the problem with the deopt fuzzer? Unfortunately the deopt > > fuzzer output doesn't say which variant it used. The flags are: > > --test --random-seed=-1766313942 --deopt-every-n-times 1000000000 > > --print-deopt-stress --nohard-abort --nodead-code-elimination > --nofold-constants > > --noconcurrent-recompilation --turbo --turbo-escape --allow-natives-syntax > > I think it should work, but it doesn't, it just prevents the test from running > at all. Hmm, yea that's unintuitive. I think matching expectations from all sections are just merged - and skip,pass is skip. For wildcards the behavior is different, e.g. you can skip foo* but explicitly run foo-run.
lgtm
Description was changed from ========== [tests] skip es6/array-iterator-turbo on deopt_fuzzer BUG=v8:5388 R=bmeurer@chromium.org ========== to ========== [tests] skip es6/array-iterator-turbo on deopt_fuzzer BUG=v8:5388 R=bmeurer@chromium.org NOTRY=true ==========
The CQ bit was unchecked by machenbach@chromium.org
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
speeding things up with notry
Message was sent while issue was closed.
Description was changed from ========== [tests] skip es6/array-iterator-turbo on deopt_fuzzer BUG=v8:5388 R=bmeurer@chromium.org NOTRY=true ========== to ========== [tests] skip es6/array-iterator-turbo on deopt_fuzzer BUG=v8:5388 R=bmeurer@chromium.org NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [tests] skip es6/array-iterator-turbo on deopt_fuzzer BUG=v8:5388 R=bmeurer@chromium.org NOTRY=true ========== to ========== [tests] skip es6/array-iterator-turbo on deopt_fuzzer BUG=v8:5388 R=bmeurer@chromium.org NOTRY=true Committed: https://crrev.com/372d905d73cf9c3851519f25d1570cef96dde165 Cr-Commit-Position: refs/heads/master@{#40974} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/372d905d73cf9c3851519f25d1570cef96dde165 Cr-Commit-Position: refs/heads/master@{#40974} |
