Support uploads of sub-rectangles of canvases to 2D and 3D textures.

Support uploads of sub-rectangles of canvases to 2D and 3D textures.

Includes the following needed WebGL conformance roll:

Roll WebGL 130f5c1..7ff1300

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/130f5c1..7ff1300

BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Committed: https://crrev.com/e424d23a8af27dd4a30f8812bcbf05d4f1980aea
Cr-Commit-Position: refs/heads/master@{#432396}

[Ken Russell (switch to Gerrit), 2016-11-12 01:47:05]

Description was changed from

==========
Support uploads of sub-rectangles of canvases to 2D and 3D textures.

BUG=639145
==========

to

==========
Support uploads of sub-rectangles of canvases to 2D and 3D textures.

BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Ken Russell (switch to Gerrit), 2016-11-12 01:48:57]

kbr@chromium.org changed reviewers:
+ kainino@chromium.org, zmo@chromium.org

[Ken Russell (switch to Gerrit), 2016-11-12 01:48:58]

Not ready for review yet. All of the 2D cases are passing, but the 3D code paths
haven't been done yet (and I haven't done the tests for them yet).

[Ken Russell (switch to Gerrit), 2016-11-14 23:24:28]

Please review. All the code paths are implemented now.

This won't have green dry-runs until a WebGL conformance roll including
https://github.com/KhronosGroup/WebGL/pull/2145 is incorporated into this CL.
I'll make that change when Kai's ImageData-to-3D-texture CL lands.

[Zhenyao Mo, 2016-11-14 23:52:29]

On 2016/11/14 23:24:28, Ken Russell wrote:
> Please review. All the code paths are implemented now.
> 
> This won't have green dry-runs until a WebGL conformance roll including
> https://github.com/KhronosGroup/WebGL/pull/2145 is incorporated into this CL.
> I'll make that change when Kai's ImageData-to-3D-texture CL lands.

lgtm

[Kai Ninomiya, 2016-11-15 00:02:12]

lgtm

[Ken Russell (switch to Gerrit), 2016-11-15 08:30:23]

Description was changed from

==========
Support uploads of sub-rectangles of canvases to 2D and 3D textures.

BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Support uploads of sub-rectangles of canvases to 2D and 3D textures.

Includes the following needed WebGL conformance roll:

Roll WebGL 130f5c1..7ff1300

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/130f5c...

BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Ken Russell (switch to Gerrit), 2016-11-15 08:31:00]

FYI, there were some bugs in the earlier patch set which I think have been fully
ironed out. Attempting to land via the CQ.

[Ken Russell (switch to Gerrit), 2016-11-15 08:31:04]

The CQ bit was checked by kbr@chromium.org

[Ken Russell (switch to Gerrit), 2016-11-15 08:31:04]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org,
kainino@chromium.org
Link to the patchset: https://codereview.chromium.org/2495953002/#ps60001
(title: "Incorporated needed WebGL conformance roll.")

[commit-bot: I haz the power, 2016-11-15 08:31:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 09:31:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 09:31:53]

Try jobs failed on following builders:
  win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)

[Ken Russell (switch to Gerrit), 2016-11-15 23:31:30]

Description was changed from

==========
Support uploads of sub-rectangles of canvases to 2D and 3D textures.

Includes the following needed WebGL conformance roll:

Roll WebGL 130f5c1..7ff1300

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/130f5c...

BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Support uploads of sub-rectangles of canvases to 2D and 3D textures.

Includes the following needed WebGL conformance roll:

Roll WebGL 130f5c1..7ff1300

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/130f5c...

BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[Ken Russell (switch to Gerrit), 2016-11-16 00:32:19]

The CQ bit was checked by kbr@chromium.org

[Ken Russell (switch to Gerrit), 2016-11-16 00:32:19]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org,
kainino@chromium.org
Link to the patchset: https://codereview.chromium.org/2495953002/#ps80001
(title: "Fixed regression in accelerated video-to-texture uploads. Marked Mac
Intel failures.")

[commit-bot: I haz the power, 2016-11-16 00:33:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 01:58:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 01:58:09]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Ken Russell (switch to Gerrit), 2016-11-16 02:25:13]

On 2016/11/16 01:58:09, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

This is an unrelated net_unittests failure and I've filed
http://crbug.com/665686 about it.

https://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu...
is a crash in V8's garbage collector and I've filed http://crbug.com/665688
about it.

https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel...
is a failure of telemetry_unittests and I've uploaded
https://codereview.chromium.org/2510503002/ disabling the affected test.

Unfortunately, the linux_chromium_rel_ng webkit_tests failures look real, and
related to my patch, and I'm investigating them now.

[yunchao, 2016-11-16 02:45:15]

yunchao.he@intel.com changed reviewers:
+ yunchao.he@intel.com

[yunchao, 2016-11-16 02:45:16]

one nit.

https://codereview.chromium.org/2495953002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl
(left):

https://codereview.chromium.org/2495953002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl:332: //
TODO(zmo): Obsolete, remove after WebGL2 conformance tests are updated.
Remove this TODO?

[Ken Russell (switch to Gerrit), 2016-11-16 02:53:57]

On 2016/11/16 02:25:13, Ken Russell wrote:
> On 2016/11/16 01:58:09, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
> >
>
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
> 
> This is an unrelated net_unittests failure and I've filed
> http://crbug.com/665686 about it.
> 
>
https://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu...
> is a crash in V8's garbage collector and I've filed http://crbug.com/665688
> about it.
> 
>
https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel...
> is a failure of telemetry_unittests and I've uploaded
> https://codereview.chromium.org/2510503002/ disabling the affected test.
> 
> Unfortunately, the linux_chromium_rel_ng webkit_tests failures look real, and
> related to my patch, and I'm investigating them now.

It turns out the linux_chromium_rel_ng failures are not caused by my patch. I
filed P0 http://crbug.com/665693 about them.

[Ken Russell (switch to Gerrit), 2016-11-16 02:54:47]

https://codereview.chromium.org/2495953002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl
(left):

https://codereview.chromium.org/2495953002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl:332: //
TODO(zmo): Obsolete, remove after WebGL2 conformance tests are updated.
On 2016/11/16 02:45:16, yunchao wrote:
> Remove this TODO? 

Not yet. We still have two more obsolete entry points to remove. Each requires
some code and tests to be written.

[Ken Russell (switch to Gerrit), 2016-11-16 03:03:43]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2016-11-16 03:04:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 04:24:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 04:24:47]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ken Russell (switch to Gerrit), 2016-11-16 04:41:44]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2016-11-16 04:42:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 06:34:09]

Description was changed from

==========
Support uploads of sub-rectangles of canvases to 2D and 3D textures.

Includes the following needed WebGL conformance roll:

Roll WebGL 130f5c1..7ff1300

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/130f5c...

BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Support uploads of sub-rectangles of canvases to 2D and 3D textures.

Includes the following needed WebGL conformance roll:

Roll WebGL 130f5c1..7ff1300

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/130f5c...

BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-11-16 06:34:10]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-11-16 06:36:34]

Description was changed from

==========
Support uploads of sub-rectangles of canvases to 2D and 3D textures.

Includes the following needed WebGL conformance roll:

Roll WebGL 130f5c1..7ff1300

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/130f5c...

BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Support uploads of sub-rectangles of canvases to 2D and 3D textures.

Includes the following needed WebGL conformance roll:

Roll WebGL 130f5c1..7ff1300

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/130f5c...

BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Committed: https://crrev.com/e424d23a8af27dd4a30f8812bcbf05d4f1980aea
Cr-Commit-Position: refs/heads/master@{#432396}
==========

[commit-bot: I haz the power, 2016-11-16 06:36:35]

Patchset 5 (id:??) landed as
https://crrev.com/e424d23a8af27dd4a30f8812bcbf05d4f1980aea
Cr-Commit-Position: refs/heads/master@{#432396}