Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6640)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/resources/settings/people_page/sync_page.js

Issue 2495933002: [MD settings][cros accounts] Updates the accounts page according to the specs (Closed)
Patch Set: Addressed comment Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/people_page/compiled_resources2.gyp ('k') | chrome/browser/resources/settings/people_page/user_list.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/people_page/sync_page.js
diff --git a/chrome/browser/resources/settings/people_page/sync_page.js b/chrome/browser/resources/settings/people_page/sync_page.js
index 9266a49effb370c81d433d81927a6da1a94254b8..7ac0f0db0e0672dfd21c4b62c5b09e8765d56071 100644
--- a/chrome/browser/resources/settings/people_page/sync_page.js
+++ b/chrome/browser/resources/settings/people_page/sync_page.js
@@ -165,9 +165,6 @@ Polymer({
/** @protected */
currentRouteChanged: function() {
- if (!this.isAttached)
- return;
-
if (settings.getCurrentRoute() == settings.Route.SYNC)
this.onNavigateToPage_();
else
@@ -185,8 +182,6 @@ Polymer({
/** @private */
onNavigateToPage_: function() {
- // The element is not ready for C++ interaction until it is attached.
- assert(this.isAttached);
assert(settings.getCurrentRoute() == settings.Route.SYNC);
if (this.unloadCallback_)
« no previous file with comments | « chrome/browser/resources/settings/people_page/compiled_resources2.gyp ('k') | chrome/browser/resources/settings/people_page/user_list.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698