src/builtins.cc - Issue 249593002: Fix C++ type of Factory::NewFixedDoubleArray.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/builtins.cc

Issue 249593002: Fix C++ type of Factory::NewFixedDoubleArray. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/builtins.cc

diff --git a/src/builtins.cc b/src/builtins.cc

index f4ce991a942d6f3db3061b632fa2da6db69f65f2..a7e1da9d5069d633482439fd75c90a797d346436 100644

--- a/src/builtins.cc

+++ b/src/builtins.cc

@@ -470,7 +470,8 @@ BUILTIN(ArrayPush) {

if (new_length > elms_len) {

// New backing storage is needed.

int capacity = new_length + (new_length >> 1) + 16;

- new_elms = isolate->factory()->NewFixedDoubleArray(capacity);

+ new_elms = Handle<FixedDoubleArray>::cast(

mvstanton 2014/04/23 16:15:17 Might have a comment that this is safe because we

+ isolate->factory()->NewFixedDoubleArray(capacity));

ElementsAccessor* accessor = array->GetElementsAccessor();

accessor->CopyElements(

« no previous file with comments | « no previous file | src/factory.h » ('j') | no next file with comments »