Issue 249593002: Fix C++ type of Factory::NewFixedDoubleArray.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 249593002: Fix C++ type of Factory::NewFixedDoubleArray. (Closed)

Created:
6 years, 8 months ago by Jarin

Modified:
6 years, 8 months ago

Reviewers:
mvstanton

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix C++ type of Factory::NewFixedDoubleArray. The change fixes the C++ type of Factory::NewFixedDoubleArray to reflect the empty array case, where we return an empty FixedArray (rather than FixedDoubleArray). R=mvstanton@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=20918

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added some comments #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -28 lines)			Patch
M	src/builtins.cc	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	src/factory.h	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
M	src/factory.cc	View		1 chunk	+10 lines, -6 lines	0 comments	Download
M	src/runtime.cc	View		2 chunks	+18 lines, -13 lines	0 comments	Download
A +	test/mjsunit/regress/regress-empty-fixed-double-array.js	View		1 chunk	+7 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mvstanton

lgtm https://codereview.chromium.org/249593002/diff/1/src/builtins.cc File src/builtins.cc (right): https://codereview.chromium.org/249593002/diff/1/src/builtins.cc#newcode473 src/builtins.cc:473: new_elms = Handle<FixedDoubleArray>::cast( Might have a comment that ...

6 years, 8 months ago (2014-04-23 16:15:16 UTC) #2

Jarin

6 years, 8 months ago (2014-04-24 05:29:08 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r20918 (presubmit successful).

Expand Messages | Collapse Messages