DevTools: Show friendly names for Parse/Compile RCS

third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 /**
  * @unrestricted
  */
 WebInspector.TimelineTreeView = class extends WebInspector.VBox {
   constructor() {
     super();
     this.element.classList.add('timeline-tree-view');
@@ skipping 304 matching lines @@
     if (columnId === 'activity')
       return this._createNameCell(columnId);
     return this._createValueCell(columnId) || super.createCell(columnId);
   }
 
   /**
    * @param {string} columnId
    * @return {!Element}
    */
   _createNameCell(columnId) {
-    var cell = this.createTD(columnId);
-    var container = cell.createChild('div', 'name-container');
-    var icon = container.createChild('div', 'activity-icon');
-    var name = container.createChild('div', 'activity-name');
-    var event = this._profileNode.event;
+    const cell = this.createTD(columnId);
+    const container = cell.createChild('div', 'name-container');
+    const icon = container.createChild('div', 'activity-icon');
+    const name = container.createChild('div', 'activity-name');
+    const event = this._profileNode.event;
     if (this._profileNode.isGroupNode()) {
-      var treeView = /** @type {!WebInspector.AggregatedTimelineTreeView} */ (this._treeView);
-      var info = treeView._displayInfoForGroupNode(this._profileNode);
+      const treeView = /** @type {!WebInspector.AggregatedTimelineTreeView} */ (this._treeView);
+      const info = treeView._displayInfoForGroupNode(this._profileNode);
       name.textContent = info.name;
       icon.style.backgroundColor = info.color;
     } else if (event) {
-      var data = event.args['data'];
-      var deoptReason = data && data['deoptReason'];
-      if (deoptReason)
+      const data = event.args['data'];
+      const deoptReason = data && data['deoptReason'];
+      if (deoptReason) {
         container.createChild('div', 'activity-warning').title =
             WebInspector.UIString('Not optimized: %s', deoptReason);
-      name.textContent = event.name === WebInspector.TimelineModel.RecordType.JSFrame ?
-          WebInspector.beautifyFunctionName(event.args['data']['functionName']) :
-          WebInspector.TimelineUIUtils.eventTitle(event);
-      var link = this._treeView._linkifyLocation(event);
+      }
+      name.textContent = event.name === WebInspector.TimelineModel.RecordType.JSFrame

[caseq, 2016/11/11 21:45:29]

Should this logic just be a part of eventTitle()?

[alph, 2016/11/11 22:29:12]

Done.

+          ? WebInspector.TimelineUIUtils.frameDisplayName(data)
+          : WebInspector.TimelineUIUtils.eventTitle(event);
+      const link = this._treeView._linkifyLocation(event);
       if (link)
         container.createChild('div', 'activity-link').appendChild(link);
       icon.style.backgroundColor = WebInspector.TimelineUIUtils.eventColor(event);
     }
     return cell;
   }
 
   /**
    * @param {string} columnId
    * @return {?Element}
@@ skipping 183 matching lines @@
      * @param {string} name
      * @param {string} id
      * @this {WebInspector.TimelineTreeView}
      */
     function addGroupingOption(name, id) {
       var option = this._groupByCombobox.createOption(name, '', id);
       this._groupByCombobox.addOption(option);
       if (id === this._groupBySetting.get())
         this._groupByCombobox.select(option);
     }
-    addGroupingOption.call(this, WebInspector.UIString('No Grouping'), WebInspector.AggregatedTimelineTreeView.GroupBy.None);
-    addGroupingOption.call(
-        this, WebInspector.UIString('Group by Activity'), WebInspector.AggregatedTimelineTreeView.GroupBy.EventName);
-    addGroupingOption.call(
-        this, WebInspector.UIString('Group by Category'), WebInspector.AggregatedTimelineTreeView.GroupBy.Category);
-    addGroupingOption.call(
-        this, WebInspector.UIString('Group by Domain'), WebInspector.AggregatedTimelineTreeView.GroupBy.Domain);
-    addGroupingOption.call(
-        this, WebInspector.UIString('Group by Subdomain'), WebInspector.AggregatedTimelineTreeView.GroupBy.Subdomain);
-    addGroupingOption.call(this, WebInspector.UIString('Group by URL'), WebInspector.AggregatedTimelineTreeView.GroupBy.URL);
-    addGroupingOption.call(this, WebInspector.UIString('Group by Frame'), WebInspector.AggregatedTimelineTreeView.GroupBy.Frame);
+    const groupBy = WebInspector.AggregatedTimelineTreeView.GroupBy;
+    addGroupingOption.call(this, WebInspector.UIString('No Grouping'), groupBy.None);
+    addGroupingOption.call(this, WebInspector.UIString('Group by Activity'), groupBy.EventName);
+    addGroupingOption.call(this, WebInspector.UIString('Group by Category'), groupBy.Category);
+    addGroupingOption.call(this, WebInspector.UIString('Group by Domain'), groupBy.Domain);
+    addGroupingOption.call(this, WebInspector.UIString('Group by Subdomain'), groupBy.Subdomain);
+    addGroupingOption.call(this, WebInspector.UIString('Group by URL'), groupBy.URL);
+    addGroupingOption.call(this, WebInspector.UIString('Group by Frame'), groupBy.Frame);
     panelToolbar.appendToolbarItem(this._groupByCombobox);
   }
 
   /**
    * @param {!WebInspector.TimelineProfileTree.Node} treeNode
    * @return {!Array<!WebInspector.TimelineProfileTree.Node>}
    */
   _buildHeaviestStack(treeNode) {
     console.assert(!!treeNode.parent, 'Attempt to build stack for tree root');
     var result = [];
@@ skipping 355 matching lines @@
 
   _onSelectionChanged() {
     this.dispatchEventToListeners(WebInspector.TimelineStackView.Events.SelectionChanged);
   }
 };
 
 /** @enum {symbol} */
 WebInspector.TimelineStackView.Events = {
   SelectionChanged: Symbol('SelectionChanged')
 };