Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2495903003: DevTools: Show friendly names for Parse/Compile RCS (Closed)

Created:
4 years, 1 month ago by alph
Modified:
4 years, 1 month ago
Reviewers:
caseq
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Show friendly names for Parse/Compile RCS BUG=660428 Committed: https://crrev.com/d87e1273de94886869865044acb0504ac6e93a6d Cr-Commit-Position: refs/heads/master@{#431718}

Patch Set 1 #

Total comments: 3

Patch Set 2 : addressing comment #

Patch Set 3 : 4 landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -61 lines) Patch
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js View 1 2 chunks +21 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js View 1 2 5 chunks +29 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineJSProfile.js View 4 chunks +53 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineProfileTree.js View 1 2 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
alph
4 years, 1 month ago (2016-11-11 20:26:29 UTC) #2
caseq
https://codereview.chromium.org/2495903003/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js File third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js (right): https://codereview.chromium.org/2495903003/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js#newcode342 third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js:342: name.textContent = event.name === WebInspector.TimelineModel.RecordType.JSFrame Should this logic just ...
4 years, 1 month ago (2016-11-11 21:45:30 UTC) #3
alph
https://codereview.chromium.org/2495903003/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js File third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js (right): https://codereview.chromium.org/2495903003/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js#newcode342 third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js:342: name.textContent = event.name === WebInspector.TimelineModel.RecordType.JSFrame On 2016/11/11 21:45:29, caseq ...
4 years, 1 month ago (2016-11-11 22:29:12 UTC) #4
caseq
lgtm https://codereview.chromium.org/2495903003/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js File third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js (right): https://codereview.chromium.org/2495903003/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js#newcode231 third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js:231: if (WebInspector.TimelineJSProfileProcessor.isNativeRuntimeFrame(frame)) { if (!..) return
4 years, 1 month ago (2016-11-11 23:30:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2495903003/40001
4 years, 1 month ago (2016-11-11 23:43:47 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/163059)
4 years, 1 month ago (2016-11-12 00:08:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2495903003/40001
4 years, 1 month ago (2016-11-12 00:33:21 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-12 01:10:38 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-12 01:15:29 UTC) #15
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/d87e1273de94886869865044acb0504ac6e93a6d
Cr-Commit-Position: refs/heads/master@{#431718}

Powered by Google App Engine
This is Rietveld 408576698