Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 2495883002: [Mac/GN] Fix //chrome:chrome_dump_syms and :chrome_dsym_archive when the framework is versioned. (Closed)

Created:
4 years, 1 month ago by Robert Sesek
Modified:
4 years, 1 month ago
Reviewers:
Nico
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac/GN] Fix //chrome:chrome_dump_syms and :chrome_dsym_archive when the framework is versioned. BUG=662466 R=thakis@chromium.org Committed: https://crrev.com/67b763d98a68f492757edf29814c5e385ad5db5d Cr-Commit-Position: refs/heads/master@{#431812}

Patch Set 1 #

Patch Set 2 : Fix unused variable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M chrome/BUILD.gn View 1 3 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Robert Sesek
4 years, 1 month ago (2016-11-11 23:11:35 UTC) #3
Nico
rs-lgtm
4 years, 1 month ago (2016-11-13 21:57:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2495883002/40001
4 years, 1 month ago (2016-11-13 21:58:06 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 1 month ago (2016-11-13 23:16:36 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-13 23:18:17 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/67b763d98a68f492757edf29814c5e385ad5db5d
Cr-Commit-Position: refs/heads/master@{#431812}

Powered by Google App Engine
This is Rietveld 408576698