Issue 2495853003: PPC: Branch instruction missing condition register

Issue 2495853003: PPC: Branch instruction missing condition register (Closed)

Created:
4 years, 1 month ago by JaideepBajwa

Modified:
4 years, 1 month ago

Reviewers:
michael_dawson, john.yan, JoranSiu

CC:
v8-reviews_googlegroups.com

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

PPC: Branch instruction missing condition register TestBit sets cr0 therefore need to pass that to the branch instruction. This got exposed with testcase added in CL https://codereview.chromium.org/2497573003/ R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Committed: https://crrev.com/a9f553bada214bf710f3b51c4454825d17aca86f Cr-Commit-Position: refs/heads/master@{#40948}

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/builtins/ppc/builtins-ppc.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2495853003/1

4 years, 1 month ago (2016-11-14 02:53:47 UTC) #4

commit-bot: I haz the power

4 years, 1 month ago (2016-11-17 22:31:47 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/a9f553bada214bf710f3b51c4454825d17aca86f
Cr-Commit-Position: refs/heads/master@{#40948}