Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 2495783002: Output list of differences to JSON file. (Closed)

Created:
4 years, 1 month ago by Yoshisato Yanagisawa
Modified:
4 years, 1 month ago
Reviewers:
Dirk Pranke, M-A Ruel
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Output list of differences to JSON file. It might be easier to investigate the reason of non-deterministic build, if we keep binaries to somewhere. To do so, let me make caller to know list of differences via JSON file. BUG=654989 Committed: https://crrev.com/a7498c76194b55b499beaf3e27ef28bbea2ea80d Cr-Commit-Position: refs/heads/master@{#431583}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M tools/determinism/compare_build_artifacts.py View 4 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Yoshisato Yanagisawa
4 years, 1 month ago (2016-11-11 09:27:00 UTC) #2
M-A Ruel
lgtm
4 years, 1 month ago (2016-11-11 16:32:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2495783002/1
4 years, 1 month ago (2016-11-11 16:32:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 16:59:22 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a7498c76194b55b499beaf3e27ef28bbea2ea80d Cr-Commit-Position: refs/heads/master@{#431583}
4 years, 1 month ago (2016-11-11 17:03:24 UTC) #8
Dirk Pranke
4 years, 1 month ago (2016-11-11 17:51:08 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698