Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 2495773003: Fast path for google_util::IsValidHostName (Closed)

Created:
4 years, 1 month ago by Charlie Harrison
Modified:
4 years, 1 month ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fast path for google_util::IsValidHostName IsValidHostName takes a host and tries to match it with [www.]<domain_in_lower_case>.<TLD> However, finding valid TLDs entails searching a big DAFSA. This patch uses a fast path to fail fast if <domain_in_lower_case> is not found in the input host. This function was seen in profiles on the IO thread in variations::AppendVariationHeaders. BUG=664174 Committed: https://crrev.com/a628b8fc2a3e19ce72cef9cd0802ad79a892f7f6 Cr-Commit-Position: refs/heads/master@{#431995}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M components/google/core/browser/google_util.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Charlie Harrison
isherman, WDYT? I think this fast path will be hit in enough cases that it ...
4 years, 1 month ago (2016-11-14 22:13:28 UTC) #6
Ilya Sherman
LGTM, thanks.
4 years, 1 month ago (2016-11-14 22:57:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2495773003/1
4 years, 1 month ago (2016-11-14 23:04:45 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-14 23:59:02 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 00:02:22 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a628b8fc2a3e19ce72cef9cd0802ad79a892f7f6
Cr-Commit-Position: refs/heads/master@{#431995}

Powered by Google App Engine
This is Rietveld 408576698