Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2495713002: [Web Payments] Should set stop propagation flag. (Closed)

Created:
4 years, 1 month ago by dhna
Modified:
4 years, 1 month ago
CC:
chromium-reviews, blink-reviews, haraken, sebsg+paymentswatch_chromium.org, rouslan+payments_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Web Payments] Should set stop propagation flag in PaymentRequestUpdateEvent::updateWith. reference from https://w3c.github.io/browser-payment-api/#updatewith set stop propagation flag is missing. BUG=587995 Committed: https://crrev.com/fffa1db7f84ef85dc99c9d821e4d1cf22eeed12f Cr-Commit-Position: refs/heads/master@{#431671}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEvent.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
dhna
@rouslan PTAL
4 years, 1 month ago (2016-11-11 00:23:45 UTC) #3
please use gerrit instead
lgtm
4 years, 1 month ago (2016-11-11 20:33:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2495713002/1
4 years, 1 month ago (2016-11-11 22:22:49 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 22:31:51 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 22:44:32 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fffa1db7f84ef85dc99c9d821e4d1cf22eeed12f
Cr-Commit-Position: refs/heads/master@{#431671}

Powered by Google App Engine
This is Rietveld 408576698