Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(975)

Issue 2495703002: Reenable XFormTest.BlendScale on ARM (Closed)

Created:
4 years, 1 month ago by enne (OOO)
Modified:
4 years, 1 month ago
Reviewers:
danakj
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reenable XFormTest.BlendScale on ARM This changes the numerical calculation to be similar to how it is calculated in practice to have the same amount of floating point error in both cases. BUG=662558 Committed: https://crrev.com/c6ef18f5d02dec16cd8f8413f75e974aadaac043 Cr-Commit-Position: refs/heads/master@{#431650}

Patch Set 1 #

Patch Set 2 : test #

Patch Set 3 : ifdef out invert test #

Patch Set 4 : ifdef out invert test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M ui/gfx/transform_unittest.cc View 1 2 3 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
enne (OOO)
4 years, 1 month ago (2016-11-11 20:55:16 UTC) #6
danakj
LGTM
4 years, 1 month ago (2016-11-11 21:23:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2495703002/60001
4 years, 1 month ago (2016-11-11 21:25:29 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-11-11 21:29:48 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 21:45:02 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c6ef18f5d02dec16cd8f8413f75e974aadaac043
Cr-Commit-Position: refs/heads/master@{#431650}

Powered by Google App Engine
This is Rietveld 408576698