Make /fastlink builds as optimized as non-/fastlink builds

Make /fastlink builds as optimized as non-/fastlink builds

The /DEBUG:FASTLINK flag is incompatible with /PROFILE, so we turn off
/PROFILE when using /DEBUG:FASTLINK. However /PROFILE turns on various
linker optimization, which means that /DEBUG:FASTLINK results in larger
binaries, for no good reason. This was causing some confusion when
working on size optimizations. This change ensures that when /PROFILE is
turned off due to /DEBUG:FASTLINK that the same linker optimization
flags are applied.

This has no effect on non-fastlink builds, it just ensures that
is_win_fastlink does not affect binary sizes. Link times (measured for
non-component 64-bit release chrome.dll and chrome_child.dll) are about
2.7 faster with fastlink than without with this change, which is inline
with before.

This change also avoids using /debug:fastlink on minimal_symbols builds.
On such builds (because there is no debug information in the .obj files
or shared .pdb files) fastlink has no value and actually makes the final
PDBs slightly *bigger*.

BUG=495670
Committed: https://crrev.com/b05140cde29b38d482e1201b77fcf68fd310daa7
Cr-Commit-Position: refs/heads/master@{#431985}

[brucedawson, 2016-11-10 19:31:32]

Description was changed from

==========
Make /fastlink builds as optimized as non-/fastlink builds

The /DEBUG:FASTLINK flag is incompatible with /PROFILE, so we turn off
/PROFILE when using /DEBUG:FASTLINK. However /PROFILE turns on various
linker optimization, which means that /DEBUG:FASTLINK results in larger
binaries, for no good reason. This was causing some confusion when
working on size optimizations. This change ensures that when /PROFILE is
turned off due to /DEBUG:FASTLINK that the same linker optimization
flags are applied.

This has no effect on non-fastlink builds, it just ensures that
is_win_fastlink does not affect binary sizes. Link times (measured for
non-component 64-bit release chrome.dll and chrome_child.dll) are about
2.7 faster with fastlink than without with this change, which is inline
with before.

BUG=495670
==========

to

==========
Make /fastlink builds as optimized as non-/fastlink builds

The /DEBUG:FASTLINK flag is incompatible with /PROFILE, so we turn off
/PROFILE when using /DEBUG:FASTLINK. However /PROFILE turns on various
linker optimization, which means that /DEBUG:FASTLINK results in larger
binaries, for no good reason. This was causing some confusion when
working on size optimizations. This change ensures that when /PROFILE is
turned off due to /DEBUG:FASTLINK that the same linker optimization
flags are applied.

This has no effect on non-fastlink builds, it just ensures that
is_win_fastlink does not affect binary sizes. Link times (measured for
non-component 64-bit release chrome.dll and chrome_child.dll) are about
2.7 faster with fastlink than without with this change, which is inline
with before.

This change also avoids using /debug:fastlink on minimal_symbols builds.
On such builds (because there is no debug information in the vc140.pdb
or .obj files) fastlink has no value and actually makes the final
PDBs *bigger*.

BUG=495670
==========

[brucedawson, 2016-11-10 19:31:41]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 19:32:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 20:23:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 20:23:39]

Dry run: This issue passed the CQ dry run.

[brucedawson, 2016-11-10 21:48:12]

brucedawson@chromium.org changed reviewers:
+ scottmg@chromium.org

[scottmg, 2016-11-10 21:56:27]

https://codereview.chromium.org/2495643002/diff/20001/build/config/win/BUILD.gn
File build/config/win/BUILD.gn (right):

https://codereview.chromium.org/2495643002/diff/20001/build/config/win/BUILD....
build/config/win/BUILD.gn:96: if (is_win_fastlink) {
I think this changes the behaviour for is_syzyasan with is_win_fastlink.

I don't think we need to support that combinations, but maybe it would be
clearer to just move the is_syzyasan to a separate if that always sets /PROFILE
and assert(!is_fastlink), and make a second that sets the linker opt flags that
doesn't consider is_syzyasan at all.

[brucedawson, 2016-11-10 22:04:06]

https://codereview.chromium.org/2495643002/diff/20001/build/config/win/BUILD.gn
File build/config/win/BUILD.gn (right):

https://codereview.chromium.org/2495643002/diff/20001/build/config/win/BUILD....
build/config/win/BUILD.gn:96: if (is_win_fastlink) {
On 2016/11/10 21:56:27, scottmg (ooo nov11) wrote:
> I think this changes the behaviour for is_syzyasan with is_win_fastlink.
> 
> I don't think we need to support that combinations, but maybe it would be
> clearer to just move the is_syzyasan to a separate if that always sets
/PROFILE
> and assert(!is_fastlink), and make a second that sets the linker opt flags
that
> doesn't consider is_syzyasan at all.

Good catch. Logic is hard. Agreed that it probably doesn't matter but we should
maintain existing logic.

[brucedawson, 2016-11-14 21:30:01]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 21:31:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brucedawson, 2016-11-14 21:34:05]

Description was changed from

==========
Make /fastlink builds as optimized as non-/fastlink builds

The /DEBUG:FASTLINK flag is incompatible with /PROFILE, so we turn off
/PROFILE when using /DEBUG:FASTLINK. However /PROFILE turns on various
linker optimization, which means that /DEBUG:FASTLINK results in larger
binaries, for no good reason. This was causing some confusion when
working on size optimizations. This change ensures that when /PROFILE is
turned off due to /DEBUG:FASTLINK that the same linker optimization
flags are applied.

This has no effect on non-fastlink builds, it just ensures that
is_win_fastlink does not affect binary sizes. Link times (measured for
non-component 64-bit release chrome.dll and chrome_child.dll) are about
2.7 faster with fastlink than without with this change, which is inline
with before.

This change also avoids using /debug:fastlink on minimal_symbols builds.
On such builds (because there is no debug information in the vc140.pdb
or .obj files) fastlink has no value and actually makes the final
PDBs *bigger*.

BUG=495670
==========

to

==========
Make /fastlink builds as optimized as non-/fastlink builds

The /DEBUG:FASTLINK flag is incompatible with /PROFILE, so we turn off
/PROFILE when using /DEBUG:FASTLINK. However /PROFILE turns on various
linker optimization, which means that /DEBUG:FASTLINK results in larger
binaries, for no good reason. This was causing some confusion when
working on size optimizations. This change ensures that when /PROFILE is
turned off due to /DEBUG:FASTLINK that the same linker optimization
flags are applied.

This has no effect on non-fastlink builds, it just ensures that
is_win_fastlink does not affect binary sizes. Link times (measured for
non-component 64-bit release chrome.dll and chrome_child.dll) are about
2.7 faster with fastlink than without with this change, which is inline
with before.

This change also avoids using /debug:fastlink on minimal_symbols builds.
On such builds (because there is no debug information in the .obj files
or shared .pdb files) fastlink has no value and actually makes the final
PDBs slightly *bigger*.

BUG=495670
==========

[brucedawson, 2016-11-14 21:34:55]

Okay, should be good now. Now this change should only affect is_win_fastlink
builds, as designed.

https://codereview.chromium.org/2495643002/diff/20001/build/config/win/BUILD.gn
File build/config/win/BUILD.gn (right):

https://codereview.chromium.org/2495643002/diff/20001/build/config/win/BUILD....
build/config/win/BUILD.gn:96: if (is_win_fastlink) {
On 2016/11/10 22:04:06, brucedawson wrote:
> On 2016/11/10 21:56:27, scottmg (ooo nov11) wrote:
> > I think this changes the behaviour for is_syzyasan with is_win_fastlink.
> > 
> > I don't think we need to support that combinations, but maybe it would be
> > clearer to just move the is_syzyasan to a separate if that always sets
> /PROFILE
> > and assert(!is_fastlink), and make a second that sets the linker opt flags
> that
> > doesn't consider is_syzyasan at all.
> 
> Good catch. Logic is hard. Agreed that it probably doesn't matter but we
should
> maintain existing logic.

Done.

[scottmg, 2016-11-14 22:38:57]

lgtm

[commit-bot: I haz the power, 2016-11-14 22:47:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 22:47:22]

Dry run: This issue passed the CQ dry run.

[brucedawson, 2016-11-14 22:51:49]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2016-11-14 22:53:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 23:49:12]

Description was changed from

==========
Make /fastlink builds as optimized as non-/fastlink builds

The /DEBUG:FASTLINK flag is incompatible with /PROFILE, so we turn off
/PROFILE when using /DEBUG:FASTLINK. However /PROFILE turns on various
linker optimization, which means that /DEBUG:FASTLINK results in larger
binaries, for no good reason. This was causing some confusion when
working on size optimizations. This change ensures that when /PROFILE is
turned off due to /DEBUG:FASTLINK that the same linker optimization
flags are applied.

This has no effect on non-fastlink builds, it just ensures that
is_win_fastlink does not affect binary sizes. Link times (measured for
non-component 64-bit release chrome.dll and chrome_child.dll) are about
2.7 faster with fastlink than without with this change, which is inline
with before.

This change also avoids using /debug:fastlink on minimal_symbols builds.
On such builds (because there is no debug information in the .obj files
or shared .pdb files) fastlink has no value and actually makes the final
PDBs slightly *bigger*.

BUG=495670
==========

to

==========
Make /fastlink builds as optimized as non-/fastlink builds

The /DEBUG:FASTLINK flag is incompatible with /PROFILE, so we turn off
/PROFILE when using /DEBUG:FASTLINK. However /PROFILE turns on various
linker optimization, which means that /DEBUG:FASTLINK results in larger
binaries, for no good reason. This was causing some confusion when
working on size optimizations. This change ensures that when /PROFILE is
turned off due to /DEBUG:FASTLINK that the same linker optimization
flags are applied.

This has no effect on non-fastlink builds, it just ensures that
is_win_fastlink does not affect binary sizes. Link times (measured for
non-component 64-bit release chrome.dll and chrome_child.dll) are about
2.7 faster with fastlink than without with this change, which is inline
with before.

This change also avoids using /debug:fastlink on minimal_symbols builds.
On such builds (because there is no debug information in the .obj files
or shared .pdb files) fastlink has no value and actually makes the final
PDBs slightly *bigger*.

BUG=495670
==========

[commit-bot: I haz the power, 2016-11-14 23:49:13]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-14 23:58:16]

Description was changed from

==========
Make /fastlink builds as optimized as non-/fastlink builds

The /DEBUG:FASTLINK flag is incompatible with /PROFILE, so we turn off
/PROFILE when using /DEBUG:FASTLINK. However /PROFILE turns on various
linker optimization, which means that /DEBUG:FASTLINK results in larger
binaries, for no good reason. This was causing some confusion when
working on size optimizations. This change ensures that when /PROFILE is
turned off due to /DEBUG:FASTLINK that the same linker optimization
flags are applied.

This has no effect on non-fastlink builds, it just ensures that
is_win_fastlink does not affect binary sizes. Link times (measured for
non-component 64-bit release chrome.dll and chrome_child.dll) are about
2.7 faster with fastlink than without with this change, which is inline
with before.

This change also avoids using /debug:fastlink on minimal_symbols builds.
On such builds (because there is no debug information in the .obj files
or shared .pdb files) fastlink has no value and actually makes the final
PDBs slightly *bigger*.

BUG=495670
==========

to

==========
Make /fastlink builds as optimized as non-/fastlink builds

The /DEBUG:FASTLINK flag is incompatible with /PROFILE, so we turn off
/PROFILE when using /DEBUG:FASTLINK. However /PROFILE turns on various
linker optimization, which means that /DEBUG:FASTLINK results in larger
binaries, for no good reason. This was causing some confusion when
working on size optimizations. This change ensures that when /PROFILE is
turned off due to /DEBUG:FASTLINK that the same linker optimization
flags are applied.

This has no effect on non-fastlink builds, it just ensures that
is_win_fastlink does not affect binary sizes. Link times (measured for
non-component 64-bit release chrome.dll and chrome_child.dll) are about
2.7 faster with fastlink than without with this change, which is inline
with before.

This change also avoids using /debug:fastlink on minimal_symbols builds.
On such builds (because there is no debug information in the .obj files
or shared .pdb files) fastlink has no value and actually makes the final
PDBs slightly *bigger*.

BUG=495670

Committed: https://crrev.com/b05140cde29b38d482e1201b77fcf68fd310daa7
Cr-Commit-Position: refs/heads/master@{#431985}
==========

[commit-bot: I haz the power, 2016-11-14 23:58:17]

Patchset 3 (id:??) landed as
https://crrev.com/b05140cde29b38d482e1201b77fcf68fd310daa7
Cr-Commit-Position: refs/heads/master@{#431985}