Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2495633002: media: Make sure we transition back to a non-loading state (Closed)

Created:
4 years, 1 month ago by hubbe
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

media: Make sure we transition back to a non-loading state An earilier bug-workaround kept the media in a loading state when a read operation was pending, but didn't always transition back to idle when the read operation was done. This CL fixes the problem by making sure that we check the loading state after read callbacks. These extra calls to check the loading state can in some cases cause us to miss progress callbacks. We fix this by allowing in-flight progress callbacks to complete even if reader_ has been destroyed. BUG=662615 Review-Url: https://codereview.chromium.org/2481673004 Cr-Commit-Position: refs/heads/master@{#430860} (cherry picked from commit a89cc8bcb5d204e3f42eb56d2db24837ba0d3a8a) Committed: https://chromium.googlesource.com/chromium/src/+/726c376476785452c478c4bc928c12c1eb62e35d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -16 lines) Patch
M media/blink/multibuffer_data_source.cc View 2 chunks +12 lines, -6 lines 0 comments Download
M media/blink/multibuffer_data_source_unittest.cc View 1 chunk +41 lines, -0 lines 0 comments Download
M media/blink/multibuffer_reader.cc View 1 chunk +5 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
hubbe
4 years, 1 month ago (2016-11-10 18:36:27 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
726c376476785452c478c4bc928c12c1eb62e35d.

Powered by Google App Engine
This is Rietveld 408576698