Roll Skia DEPS to 14324 from 14292

Roll Skia DEPS to 14324 from 14292

Control: https://codereview.chromium.org/246073010

NOTRY=true
R=reed@google.com, robertphillips@google.com

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265696

[bsalomon, 2014-04-23 18:09:02]

We just might get a roll in today.

[reed1, 2014-04-23 18:15:28]

On 2014/04/23 18:09:02, bsalomon wrote:
> We just might get a roll in today.

win_blink_dbg seems to have not seen the changes in benchmarking_canvas.cc :(

[bsalomon, 2014-04-23 18:25:14]

On 2014/04/23 18:15:28, reed1 wrote:
> On 2014/04/23 18:09:02, bsalomon wrote:
> > We just might get a roll in today.
> 
> win_blink_dbg seems to have not seen the changes in benchmarking_canvas.cc :(

Looks like the failure was that it tried to run a comparison against a build
with the patch reverted. However, when it reverts the patch it doesn't re-run
gclient runhooks. So the comparison build had new skia without the necessary Cr
changes.

[bsalomon, 2014-04-23 18:30:57]

On 2014/04/23 18:25:14, bsalomon wrote:
> On 2014/04/23 18:15:28, reed1 wrote:
> > On 2014/04/23 18:09:02, bsalomon wrote:
> > > We just might get a roll in today.
> > 
> > win_blink_dbg seems to have not seen the changes in benchmarking_canvas.cc
:(
> 
> Looks like the failure was that it tried to run a comparison against a build
> with the patch reverted. However, when it reverts the patch it doesn't re-run
> gclient runhooks. So the comparison build had new skia without the necessary
Cr
> changes.

By "gclient runhooks" I meant "gclient sync"

[reed1, 2014-04-23 18:32:39]

On 2014/04/23 18:30:57, bsalomon wrote:
> On 2014/04/23 18:25:14, bsalomon wrote:
> > On 2014/04/23 18:15:28, reed1 wrote:
> > > On 2014/04/23 18:09:02, bsalomon wrote:
> > > > We just might get a roll in today.
> > > 
> > > win_blink_dbg seems to have not seen the changes in benchmarking_canvas.cc
> :(
> > 
> > Looks like the failure was that it tried to run a comparison against a build
> > with the patch reverted. However, when it reverts the patch it doesn't
re-run
> > gclient runhooks. So the comparison build had new skia without the necessary
> Cr
> > changes.

Bug :(

> 
> By "gclient runhooks" I meant "gclient sync"

[reed1, 2014-04-23 18:32:46]

lgtm

[bsalomon, 2014-04-23 18:35:13]

On 2014/04/23 18:32:39, reed1 wrote:
> On 2014/04/23 18:30:57, bsalomon wrote:
> > On 2014/04/23 18:25:14, bsalomon wrote:
> > > On 2014/04/23 18:15:28, reed1 wrote:
> > > > On 2014/04/23 18:09:02, bsalomon wrote:
> > > > > We just might get a roll in today.
> > > > 
> > > > win_blink_dbg seems to have not seen the changes in
benchmarking_canvas.cc
> > :(
> > > 
> > > Looks like the failure was that it tried to run a comparison against a
build
> > > with the patch reverted. However, when it reverts the patch it doesn't
> re-run
> > > gclient runhooks. So the comparison build had new skia without the
necessary
> > Cr
> > > changes.
> 
> Bug :(

Yeah, there is one here: http://crbug.com/358528
> 
> > 
> > By "gclient runhooks" I meant "gclient sync"

[robertphillips, 2014-04-23 18:49:03]

lgtm

[bsalomon, 2014-04-23 18:53:39]

Committed patchset #2 manually as r265696 (presubmit successful).