third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-request-child-nodes-traverse-frames.html - Issue 2495623002: Rename traverseFrames to pierce and traverse shadow dom too.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-request-child-nodes-traverse-frames.html

Issue 2495623002: Rename traverseFrames to pierce and traverse shadow dom too. (Closed)

Patch Set: Rename traverseFrames to pierce. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « headless/public/util/dom_tree_extractor.cc ('k') | third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-request-document-with-child-nodes.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-request-child-nodes-traverse-frames.html

diff --git a/third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-request-child-nodes-traverse-frames.html b/third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-request-child-nodes-traverse-frames.html

index 1e5b6d992869ef0ba614fb546bf72c82df4647be..58f9bd2af26ce9f13d2e8935da5b7d62d9aac389 100644

--- a/third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-request-child-nodes-traverse-frames.html

+++ b/third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-request-child-nodes-traverse-frames.html

@@ -39,7 +39,7 @@ function test()

function getDocumentIncludingIframe()

{

- InspectorTest.sendCommand("DOM.getDocument", {"traverseFrames": true}, function(messageObject) {

+ InspectorTest.sendCommand("DOM.getDocument", {"pierce": true}, function(messageObject) {

if (messageObject.hasOwnProperty("error"))

InspectorTest.log("Backend error: " + messageObject.error.message + " (" + messageObject.error.code + ")\n");

@@ -63,7 +63,7 @@ function test()

function requestAllChildNodesIncludingIframe(bodyId)

{

- InspectorTest.sendCommand("DOM.requestChildNodes", {"nodeId": bodyId, "depth": -1, "traverseFrames": true}, function(messageObject) {

+ InspectorTest.sendCommand("DOM.requestChildNodes", {"nodeId": bodyId, "depth": -1, "pierce": true}, function(messageObject) {

if (messageObject.hasOwnProperty("error"))

InspectorTest.log("Backend error: " + messageObject.error.message + " (" + messageObject.error.code + ")\n");

});