Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Unified Diff: third_party/WebKit/Source/core/inspector/browser_protocol.json

Issue 2495623002: Rename traverseFrames to pierce and traverse shadow dom too. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/inspector/browser_protocol.json
diff --git a/third_party/WebKit/Source/core/inspector/browser_protocol.json b/third_party/WebKit/Source/core/inspector/browser_protocol.json
index 08acb7bd0cc6490b65856a9dc16f2585a5037d7b..0c150b687fdd471ea906bf3a2ca8c62054b938cb 100644
--- a/third_party/WebKit/Source/core/inspector/browser_protocol.json
+++ b/third_party/WebKit/Source/core/inspector/browser_protocol.json
@@ -2122,7 +2122,7 @@
"name": "getDocument",
"parameters": [
{ "name": "depth", "type": "integer", "optional": true, "description": "The maximum depth at which children should be retrieved, defaults to 1. Use -1 for the entire subtree or provide an integer larger than 0.", "experimental": true },
- { "name": "traverseFrames", "type": "boolean", "optional": true, "description": "Whether or not iframes should be traversed when returning the subtree (default is false).", "experimental": true }
+ { "name": "traverseFrames", "type": "boolean", "optional": true, "description": "Whether or not iframes and shadow roots should be traversed when returning the subtree (default is false).", "experimental": true }
Sami 2016/11/11 15:29:42 I'll leave this up to you but it feels a little we
alex clarke (OOO till 29th) 2016/11/14 16:25:25 The use case I had in mind doesn't need it but we
pfeldman 2016/11/14 18:35:06 No strong preference. We can call it in an intenti
],
"returns": [
{ "name": "root", "$ref": "Node", "description": "Resulting node." }
@@ -2145,7 +2145,7 @@
"parameters": [
{ "name": "nodeId", "$ref": "NodeId", "description": "Id of the node to get children for." },
{ "name": "depth", "type": "integer", "optional": true, "description": "The maximum depth at which children should be retrieved, defaults to 1. Use -1 for the entire subtree or provide an integer larger than 0.", "experimental": true },
- { "name": "traverseFrames", "type": "boolean", "optional": true, "description": "Whether or not iframes should be traversed when returning the sub-tree (default is false).", "experimental": true }
+ { "name": "traverseFrames", "type": "boolean", "optional": true, "description": "Whether or not iframes and shadow roots should be traversed when returning the sub-tree (default is false).", "experimental": true }
],
"description": "Requests that children of the node with given id are returned to the caller in form of <code>setChildNodes</code> events where not only immediate children are retrieved, but all children down to the specified depth."
},
« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698