Allow a URI to designate a library as of a "part of" declaration.

Allow a URI to designate a library as of a "part of" declaration.

[Lasse Reichstein Nielsen, 2016-11-11 09:25:35]

lrn@google.com changed reviewers:
+ eernst@google.com, floitsch@google.com

[eernst, 2016-11-11 10:37:42]

LGTM, with just one question.

https://codereview.chromium.org/2495613004/diff/1/docs/language/dartLangSpec.tex
File docs/language/dartLangSpec.tex (right):

https://codereview.chromium.org/2495613004/diff/1/docs/language/dartLangSpec....
docs/language/dartLangSpec.tex:7000: Otherwise, any relative URI reference is
interpreted as relative to the location of the current library. All further
interpretation of URIs is implementation dependent.
I cannot find any other occurrences of `URI reference` in the spec. Why is the
addition of `reference` needed here?

[Lasse Reichstein Nielsen, 2016-11-18 09:50:25]

We're probably not changing this for 1.50.
(Still, I have implementations for the VM and dart2js if we change our minds).

https://codereview.chromium.org/2495613004/diff/1/docs/language/dartLangSpec.tex
File docs/language/dartLangSpec.tex (right):

https://codereview.chromium.org/2495613004/diff/1/docs/language/dartLangSpec....
docs/language/dartLangSpec.tex:7000: Otherwise, any relative URI reference is
interpreted as relative to the location of the current library. All further
interpretation of URIs is implementation dependent.
Because a URI cannot be relative, but a URI reference can. It's all part of the
nitty gritty details of RFC-3986, but a relative path is not a "URI". You
resolve a URI reference relative to a URI to produce a new URI.

Our Uri class confuses this by covering both URI and URI reference - because
most users don't know the difference and can't be bothered to distinguish - but
the spec shouldn't be excused for not knowing what the words it uses actually
means.

[eernst, 2016-11-18 13:12:06]

And still LGTM, of course.

https://codereview.chromium.org/2495613004/diff/1/docs/language/dartLangSpec.tex
File docs/language/dartLangSpec.tex (right):

https://codereview.chromium.org/2495613004/diff/1/docs/language/dartLangSpec....
docs/language/dartLangSpec.tex:7000: Otherwise, any relative URI reference is
interpreted as relative to the location of the current library. All further
interpretation of URIs is implementation dependent.
On 2016/11/18 09:50:24, Lasse Reichstein Nielsen wrote:
> Because a URI cannot be relative, but a URI reference can. It's all part of
the
> nitty gritty details of RFC-3986, but a relative path is not a "URI". You
> resolve a URI reference relative to a URI to produce a new URI.
> 
> Our Uri class confuses this by covering both URI and URI reference - because
> most users don't know the difference and can't be bothered to distinguish -
but
> the spec shouldn't be excused for not knowing what the words it uses actually
> means.

Wow! - acknowledged.