Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 2495613003: comment out getBufferSubDataAsync so conformance2/context/methods-2.html can pass (Closed)

Created:
4 years, 1 month ago by Kai Ninomiya
Modified:
4 years, 1 month ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, blink-reviews, jam, haraken, darin-cc_chromium.org, piman+watch_chromium.org, Ken Russell (switch to Gerrit)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

comment out getBufferSubDataAsync so conformance2/context/methods-2.html can pass BUG=616554 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/d48a591afbf8243b00496ce097c10e98e500e585 Cr-Commit-Position: refs/heads/master@{#431775}

Patch Set 1 #

Patch Set 2 : update global interface listing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M content/test/gpu/gpu_tests/webgl2_conformance_expectations.py View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 22 (17 generated)
Kai Ninomiya
zmo (or kbr), PTAL.
4 years, 1 month ago (2016-11-12 03:40:31 UTC) #16
Zhenyao Mo
On 2016/11/12 03:40:31, Kai Ninomiya wrote: > zmo (or kbr), PTAL. lgtm
4 years, 1 month ago (2016-11-12 05:14:45 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2495613003/20001
4 years, 1 month ago (2016-11-12 05:14:59 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-12 05:19:34 UTC) #20
commit-bot: I haz the power
4 years, 1 month ago (2016-11-12 05:22:18 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d48a591afbf8243b00496ce097c10e98e500e585
Cr-Commit-Position: refs/heads/master@{#431775}

Powered by Google App Engine
This is Rietveld 408576698