Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 2495613002: Revert of wptserve: Enable WPTServe by default. (Closed)

Created:
4 years, 1 month ago by Dirk Pranke
Modified:
4 years, 1 month ago
Reviewers:
tkent, jsbell, qyearsley
CC:
blink-reviews, chromium-reviews, Rick Byers
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of wptserve: Enable WPTServe by default. (patchset #1 id:1 of https://codereview.chromium.org/2482793002/ ) Reason for revert: I'm reverting this because I think imported/wpt/html/browsers/history/the-location-interface/reload_post_1.html started failing with the switch on windows, see https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/8056 and I'm the sheriff today. However, I'm also concerned that I think you missed my comments in #10. I don't think a 30% cycle time regression is okay, at least not without an explanation and a plan for addressing it. Original issue's description: > wptserve: Enable WPTServe by default. > > Feel free to revert this if you see stability issues of imported/wpt tests in > webkit_tests step. > > BUG=618366 > > Committed: https://crrev.com/311d6ccdab758c38b0394a06d054a4db15a5fa21 > Cr-Commit-Position: refs/heads/master@{#431186} TBR=qyearsley@chromium.org,jsbell@chromium.org,tkent@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=618366 Committed: https://crrev.com/05bb9406c894324faea17e0b4cc78bcfffafcff4 Cr-Commit-Position: refs/heads/master@{#431285}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Dirk Pranke
Created Revert of wptserve: Enable WPTServe by default.
4 years, 1 month ago (2016-11-10 17:53:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2495613002/1
4 years, 1 month ago (2016-11-10 17:54:12 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-10 17:55:07 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/05bb9406c894324faea17e0b4cc78bcfffafcff4 Cr-Commit-Position: refs/heads/master@{#431285}
4 years, 1 month ago (2016-11-10 18:08:26 UTC) #7
tkent
lgtm
4 years, 1 month ago (2016-11-10 21:03:04 UTC) #8
tkent
4 years, 1 month ago (2016-11-14 02:14:52 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2497193002/ by tkent@chromium.org.

The reason for reverting is: The issue was resolved.  Try to reland without any
changes.
.

Powered by Google App Engine
This is Rietveld 408576698