Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2495593003: scheduler: Handle mouse wheel event disposition correctly (Closed)

Created:
4 years, 1 month ago by Sami
Modified:
4 years, 1 month ago
CC:
chromium-reviews, blink-reviews, scheduler-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

scheduler: Handle mouse wheel event disposition correctly Previously the renderer scheduler would treat mouse wheel events as prioritized events, but failed to keep track of whether they were processed (and preventDefault()'ed) on the main thread or whether they turned into a smooth scroll gesture. Making this distinction is important because in the former case the main thread is doing custom input handling (which we should be careful about scheduling) and in the latter we are dealing with a regular scroll gesture handled either by the main or the compositor thread. This patch fixes the problem by adding explicit processing for the MouseWheel event and a number of tests which cover all the relevant scenarios. BUG=654765 Committed: https://crrev.com/4867673a4d5bad7c3030ac7bab0ee5bf41a6f634 Cr-Commit-Position: refs/heads/master@{#431321}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -3 lines) Patch
M third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc View 2 chunks +62 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Sami
4 years, 1 month ago (2016-11-10 18:15:48 UTC) #3
alex clarke (OOO till 29th)
lgtm
4 years, 1 month ago (2016-11-10 18:19:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2495593003/1
4 years, 1 month ago (2016-11-10 18:23:18 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-10 19:46:59 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 20:10:42 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4867673a4d5bad7c3030ac7bab0ee5bf41a6f634
Cr-Commit-Position: refs/heads/master@{#431321}

Powered by Google App Engine
This is Rietveld 408576698