Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2495553003: media remoting: Fix gn deps (Closed)

Created:
4 years, 1 month ago by xhwang
Modified:
4 years, 1 month ago
Reviewers:
brettw, *erickung1, miu
CC:
chromium-reviews, feature-media-reviews_chromium.org, xjz+watch_chromium.org, miu+watch_chromium.org, apacible+watch_chromium.org, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media remoting: Fix gn deps Also enable "gn check" on //media/remoting/* BUG=599578, 643964 Committed: https://crrev.com/09f35d95e99f3284a3a483fd0356704b009ccdf1 Cr-Commit-Position: refs/heads/master@{#431596}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M .gn View 1 chunk +1 line, -0 lines 0 comments Download
M media/remoting/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
xhwang
erickung: PTAL miu: FYI
4 years, 1 month ago (2016-11-11 06:32:15 UTC) #5
miu
lgtm
4 years, 1 month ago (2016-11-11 08:01:03 UTC) #6
xhwang
brettw@chromium.org: Please review changes in .gn file.
4 years, 1 month ago (2016-11-11 08:03:55 UTC) #8
erickung1
lgtm
4 years, 1 month ago (2016-11-11 16:50:50 UTC) #11
brettw
lgtm
4 years, 1 month ago (2016-11-11 18:05:30 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2495553003/1
4 years, 1 month ago (2016-11-11 18:07:59 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 18:12:52 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 18:28:07 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/09f35d95e99f3284a3a483fd0356704b009ccdf1
Cr-Commit-Position: refs/heads/master@{#431596}

Powered by Google App Engine
This is Rietveld 408576698