Issue 2495543002: [Interpreter] Fix logical-or/and to ensure it always visits the lhs.

Issue 2495543002: [Interpreter] Fix logical-or/and to ensure it always visits the lhs. (Closed)

Created:
4 years, 1 month ago by rmcilroy

Modified:
4 years, 1 month ago

Reviewers:
Michael Starzinger

CC:
v8-reviews_googlegroups.com, rmcilroy

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

[Interpreter] Fix logical-or/and to ensure it always visits the lhs. BUG=chromium:664146 Committed: https://crrev.com/f50f19eb1915c78dee0adf8b5691c1f6a9121d03 Cr-Commit-Position: refs/heads/master@{#40904}

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -2 lines)			Patch
	M	src/interpreter/bytecode-generator.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	A	test/mjsunit/ignition/regress-664146.js	View	1	1 chunk	+27 lines, -0 lines	0 comments	Download

Total messages: 14 (9 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2495543002/20001

4 years, 1 month ago (2016-11-10 16:28:20 UTC) #11

commit-bot: I haz the power

4 years, 1 month ago (2016-11-17 22:29:44 UTC) #14

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/f50f19eb1915c78dee0adf8b5691c1f6a9121d03
Cr-Commit-Position: refs/heads/master@{#40904}