Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2495533003:
Fix memory leak in test. (Closed)
DescriptionFix memory leak in cctest/parsing/test-scanner.
BUG=chromium:662388
Committed: https://crrev.com/56daccb8368c459087f20b1177ee22bea4de118e
Cr-Commit-Position: refs/heads/master@{#41266}
Patch Set 1 #Patch Set 2 : minor cleanup. #Patch Set 3 : Try to please MSVC++ #Patch Set 4 : Try to please MSVC++ even harder. #
Total comments: 1
Messages
Total messages: 24 (17 generated)
The CQ bit was checked by vogelheim@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by vogelheim@chromium.org
Description was changed from ========== Fix memory leak in test. BUG=chromium:662388 ========== to ========== Fix memory leak in cctest/parsing/test-scanner. BUG=chromium:662388 ==========
The CQ bit was checked by vogelheim@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/18314) v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/2...)
The CQ bit was checked by vogelheim@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
vogelheim@chromium.org changed reviewers: + ahaas@chromium.org
ptal. This is a follow-on to crrev.com/2468423008.
https://codereview.chromium.org/2495533003/diff/60001/test/cctest/parsing/tes... File test/cctest/parsing/test-scanner.cc (right): https://codereview.chromium.org/2495533003/diff/60001/test/cctest/parsing/tes... test/cctest/parsing/test-scanner.cc:20: struct ScannerTestHelper { This (& below) is an awful lot of boilerplate, just so that I can ignore memory management in the tests themselves. I hope this makes the tests more readable, but... not sure. Let me know if you disagree, or have a better idea.
Test failures on v8_linux64_sanitizer_coverage_rel are unrelated. The test failures that this CL addresses are indeed gone in this build.
On 2016/11/23 at 18:15:46, vogelheim wrote: > Test failures on v8_linux64_sanitizer_coverage_rel are unrelated. The test failures that this CL addresses are indeed gone in this build. nice, lgtm
The CQ bit was checked by vogelheim@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1479997635411460,
"parent_rev": "f991b1f476da84f54b06a5d6d11ddbf8353ff0b4", "commit_rev":
"5c4a937fb615144f04aee9fe28319783054f429b"}
Message was sent while issue was closed.
Description was changed from ========== Fix memory leak in cctest/parsing/test-scanner. BUG=chromium:662388 ========== to ========== Fix memory leak in cctest/parsing/test-scanner. BUG=chromium:662388 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Fix memory leak in cctest/parsing/test-scanner. BUG=chromium:662388 ========== to ========== Fix memory leak in cctest/parsing/test-scanner. BUG=chromium:662388 Committed: https://crrev.com/56daccb8368c459087f20b1177ee22bea4de118e Cr-Commit-Position: refs/heads/master@{#41266} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/56daccb8368c459087f20b1177ee22bea4de118e Cr-Commit-Position: refs/heads/master@{#41266} |
