third_party/protobuf/js/binary/proto_test.js - Issue 2495533002: third_party/protobuf: Update to HEAD (83d681ee2c)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/protobuf/js/binary/proto_test.js

Issue 2495533002: third_party/protobuf: Update to HEAD (83d681ee2c) (Closed)

Patch Set: Update to new HEAD (b7632464b4) + restore GOOGLE_PROTOBUF_NO_STATIC_INITIALIZER Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/protobuf/js/binary/proto_test.js

diff --git a/third_party/protobuf/js/binary/proto_test.js b/third_party/protobuf/js/binary/proto_test.js

index 14d0f42e9549b64389b7c85cb3f0cfc387377e53..26e1d30f1c21d7ee8653439affb6b54bf84142f0 100644

--- a/third_party/protobuf/js/binary/proto_test.js

+++ b/third_party/protobuf/js/binary/proto_test.js

@@ -496,7 +496,7 @@ describe('protoBinaryTest', function() {

msg.setRepeatedBytesList([BYTES_B64, BYTES_B64]);

assertGetters();

- msg.setRepeatedBytesList(null);

+ msg.setRepeatedBytesList([]);

assertEquals(0, msg.getRepeatedBytesList().length);

assertEquals(0, msg.getRepeatedBytesList_asB64().length);

assertEquals(0, msg.getRepeatedBytesList_asU8().length);