third_party/protobuf/src/google/protobuf/compiler/csharp/csharp_field_base.cc - Issue 2495533002: third_party/protobuf: Update to HEAD (83d681ee2c)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/protobuf/src/google/protobuf/compiler/csharp/csharp_field_base.cc

Issue 2495533002: third_party/protobuf: Update to HEAD (83d681ee2c) (Closed)

Patch Set: Make chrome settings proto generated file a component Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/protobuf/src/google/protobuf/compiler/csharp/csharp_enum.cc ('k') | third_party/protobuf/src/google/protobuf/compiler/csharp/csharp_generator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/protobuf/src/google/protobuf/compiler/csharp/csharp_field_base.cc

diff --git a/third_party/protobuf/src/google/protobuf/compiler/csharp/csharp_field_base.cc b/third_party/protobuf/src/google/protobuf/compiler/csharp/csharp_field_base.cc

index e3c34040b8fe4a37612e82286d29bdd92e34b058..e2011b76ca282d64acc9f384f7531ff4a459c915 100644

--- a/third_party/protobuf/src/google/protobuf/compiler/csharp/csharp_field_base.cc

+++ b/third_party/protobuf/src/google/protobuf/compiler/csharp/csharp_field_base.cc

@@ -124,12 +124,13 @@ void FieldGeneratorBase::GenerateCodecCode(io::Printer* printer) {

void FieldGeneratorBase::AddDeprecatedFlag(io::Printer* printer) {

if (descriptor_->options().deprecated())

{

- printer->Print("[global::System.ObsoleteAttribute()]\n");

+ printer->Print("[global::System.ObsoleteAttribute]\n");

}

void FieldGeneratorBase::AddPublicMemberAttributes(io::Printer* printer) {

AddDeprecatedFlag(printer);

+ WriteGeneratedCodeAttributes(printer);

}

std::string FieldGeneratorBase::oneof_property_name() {