third_party/protobuf/src/google/protobuf/compiler/cpp/cpp_bootstrap_unittest.cc - Issue 2495533002: third_party/protobuf: Update to HEAD (83d681ee2c)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/protobuf/src/google/protobuf/compiler/cpp/cpp_bootstrap_unittest.cc

Issue 2495533002: third_party/protobuf: Update to HEAD (83d681ee2c) (Closed)

Patch Set: Make chrome settings proto generated file a component Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/protobuf/src/google/protobuf/compiler/command_line_interface_unittest.cc ('k') | third_party/protobuf/src/google/protobuf/compiler/cpp/cpp_enum.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/protobuf/src/google/protobuf/compiler/cpp/cpp_bootstrap_unittest.cc

diff --git a/third_party/protobuf/src/google/protobuf/compiler/cpp/cpp_bootstrap_unittest.cc b/third_party/protobuf/src/google/protobuf/compiler/cpp/cpp_bootstrap_unittest.cc

index 77451ab1bff81b2377da93af2f661d98021e8630..bf4e58319c641c739573b290316619d752df0b47 100644

--- a/third_party/protobuf/src/google/protobuf/compiler/cpp/cpp_bootstrap_unittest.cc

+++ b/third_party/protobuf/src/google/protobuf/compiler/cpp/cpp_bootstrap_unittest.cc

@@ -99,7 +99,6 @@ class MockGeneratorContext : public GeneratorContext {

&actual_contents, true));

EXPECT_TRUE(actual_contents == *expected_contents)

<< physical_filename << " needs to be regenerated. Please run "

- "google/protobuf/compiler/release_compiler.sh and "

"generate_descriptor_proto.sh. Then add this file "

"to your CL.";

}

@@ -115,7 +114,7 @@ class MockGeneratorContext : public GeneratorContext {

}

private:

- map<string, string*> files_;

+ std::map<string, string*> files_;

};

TEST(BootstrapTest, GeneratedDescriptorMatches) {