third_party/protobuf/csharp/src/Google.Protobuf.Test/FieldCodecTest.cs - Issue 2495533002: third_party/protobuf: Update to HEAD (83d681ee2c)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/protobuf/csharp/src/Google.Protobuf.Test/FieldCodecTest.cs

Issue 2495533002: third_party/protobuf: Update to HEAD (83d681ee2c) (Closed)

Patch Set: Make chrome settings proto generated file a component Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/protobuf/csharp/src/Google.Protobuf.Test/DeprecatedMemberTest.cs ('k') | third_party/protobuf/csharp/src/Google.Protobuf.Test/GeneratedMessageTest.cs » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/protobuf/csharp/src/Google.Protobuf.Test/FieldCodecTest.cs

diff --git a/third_party/protobuf/csharp/src/Google.Protobuf.Test/FieldCodecTest.cs b/third_party/protobuf/csharp/src/Google.Protobuf.Test/FieldCodecTest.cs

index c616470e81fc6e8821283c68f87e2b5855659823..0e2bad59e5fcf89ecb3ba3894a75fba45130938a 100644

--- a/third_party/protobuf/csharp/src/Google.Protobuf.Test/FieldCodecTest.cs

+++ b/third_party/protobuf/csharp/src/Google.Protobuf.Test/FieldCodecTest.cs

@@ -32,6 +32,7 @@

using System.Collections.Generic;

using System.IO;

+using System.Reflection;

using Google.Protobuf.TestProtos;

using NUnit.Framework;

@@ -162,7 +163,7 @@ namespace Google.Protobuf

codedOutput.Flush();

Assert.AreEqual(0, stream.Position);

Assert.AreEqual(0, codec.CalculateSizeWithTag(codec.DefaultValue));

- if (typeof(T).IsValueType)

+ if (typeof(T).GetTypeInfo().IsValueType)

{

Assert.AreEqual(default(T), codec.DefaultValue);

}